BadOptimizations

BadOptimizations

18M Downloads

Lighting from the sun doesn't update smoothly

Closed this issue ยท 11 comments

commented

See the attached video
I used a snow biome so that it might be easier to see, but it happens everywhere really, if you want to test in the same biome, the seed is -1922697271287446582
And its 1.20.4

output22.mp4
commented

Are you talking about sky colors or block lighting?

commented

Are you talking about sky colors or block lighting?

Both, cause it seems both are affected by this bug

commented
commented

Try this

I'm still having the same issue. Btw, I find that I can test it easily by setting the time to 0 (/time set 0) and watch as the world lights up from the sunrise

commented

Is the issue at least mitigated with the custom jar? Or is it just the same as it was before?

commented

Is the issue at least mitigated with the custom jar? Or is it just the same as it was before?

Actually, yes. It seems like the lighting updates more frequently. When stationary, it's still very noticeable although when running around, it can be hard to notice, but the sky still is very noticeable to me even when moving around.

commented

It seems like the lighting updates more frequently.

Yes, that's what I did. There's a threshold for how much the time needs to change for the lightmaps and sky colors to update, which means I need to cherry pick a specific threshold that people won't notice. I picked it while at a higher brightness where differences were less noticeable.

commented

For that custom jar, I lowered the threshold a bit for both sky colors and lightmaps, but at this point I might just need to find an equation to update the sky color & lightnap cache according to time without recalculating the entire thing.

commented

good luck with that bro ๐Ÿ’ช

commented

Are you able to tell the difference from vanilla in sky color when using this?
Ignore cloud color, I'll fix that next.

commented

Are you able to tell the difference from vanilla in sky color when using this? Ignore cloud color, I'll fix that next.

nope ๐Ÿ‘