BadOptimizations

BadOptimizations

18M Downloads

@Redirect conflicts causes a crash

Closed this issue · 10 comments

commented

It would be nice to have a config option to disable certain optimizations in case crashes like this happen. Im using BadOptimizations version 2.0.0 (MC 1.20.1)

latest.log

commented

Can confirm Mixins crash after updating 1.6.3 -> 2.0.0 on NeoForge 47.1.98 with a long list of mods. Downgrading to 1.6.3 for now.

Crash report: https://pastebin.com/V0pXP419

commented

i also crashed causing all mods to fail link

commented

Not very surprised there's a lot of crashes in a big new version like this. Mostly looks pretty easy to fix, I'll fix it when I get home in 1-3 hours.

Expect a bug fix release by tomorrow.

commented

Not very surprised there's a lot of crashes in a big new version like this. Mostly looks pretty easy to fix, I'll fix it when I get home in 1-3 hours.

Expect a bug fix release by tomorrow.

Thank you for fast reply and your work <3 Looking forward for update!

commented

Does this modified 1.20.1 version fix the crash?
mod.zip

commented

Yes this issue is resolved for me using this new version of the jar.. i was previously getting a crash a launch referencing Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector getSkyAngle(Lnet/minecraft/client/multiplayer/ClientLevel;FLcom/llamalad7/mixinextras/sugar/ref/LocalFloatRef;)F in forge-badoptimizations.mixins.json:MixinWorldRenderer failed injection check, ---- etc. Which is now fixed!

commented

Great, I'll fix some other bugs and release this as 2.0.1.

commented

First.
Sorry.

Expect a bug fix release by tomorrow.

I have nobody to blame but myself.
I procrastinate too much.
On the bright side, 2.0.1 is now out with the fix.

commented

First.

Sorry.

Expect a bug fix release by tomorrow.

I have nobody to blame but myself.

I procrastinate too much.

On the bright side, 2.0.1 is now out with the fix.

When will the curseforge update come out?

commented

When will the curseforge update come out?

All the versions are "under review." Which is weird, usually it only takes like 5-7 minutes.
I can't control that, so for now you should download off modrinth.