BadOptimizations

BadOptimizations

18M Downloads

incompatibility with SideKick mod

Closed this issue ยท 7 comments

commented

This mod (https://modrinth.com/plugin/sidekick) adds a new Creative Menu, where you can activate special functions, such as "Full Bright"
image

However, when trying to activate this function together with BadOptimizations, some problems occur

  1. BadOptimizations considers "Full Bright" as a normal change in the light of the world, so it is only updated after a few ticks, according to the option "lightmap_time_change_needed_for_update:"

  2. when the doDaylightCycle gamerule is disabled, Full Bright does not work (since the time isnt changing), you need to manually change the time of day (like /time set 13500), so BadOptimizations understands lightmap should change


  • how to reproduce:

install both mods
enter in a creative world
type /time set night
type /gamerule doDaylightCycle false
open the new Creative Menu and enable "Full Bright" option
wait to see if something changes
type /time set 13500 to advance the night


  • what is expected:

the "Full Bright" function stands out over the BadOptimizations settings

commented

forgot to say: im using Fabric 1.20.1
BadOptimizations 2.1.0
Sidekick v2.0.5

if is possible to fix this pls publish an update to 1.20.1, tx

commented

Probably not fixable due to their implementation of it. However is there any reason you can't use something else like Boosted Brightness? It's still toggleable.

commented

I understand
the Sidekick is more practical as it is an on/off button

commented

Boosted Brightness has customizable hotkeys to increase/decrease its brightness.

commented

i see

commented

So uhm...is your issue fixed?

commented

you can close the Issue, as I know what caused the problem, its easier to get around it