BadOptimizations

BadOptimizations

18M Downloads

Skybox randomly turning gray

Closed this issue ยท 36 comments

commented

2024-04-12_02 29 14
2024-04-12_02 29 16

2024-04-12_02 29 39
2024-04-12_02 29 40

The skybox changes color from the normal light blue to a much darker gray seemingly at random. It is based on position, in that on some coords it is blue and on some coords it is gray, but it's not really consistent and the affected areas tend to change on relog. It doesn't seem to adhere to chunk borders.

My friend has the same issue, and they have fewer mods than me so I'll list their mods instead to help narrow down potential conflicts. I have all these mods installed too. Both my friend and I got this issue shortly after installing BadOptimizations 2.1.0.

Mods (Fabric 1.20.4):
BadOptimizations
Bobby
Craftify
Cubes Without Borders
DynamicFPS
Enhanced Block Entities
EntityCulling
Exordium
FerriteCore
ImmediatelyFast
Indium
Krypton
Lithium
Memory Leak Fix
Mod Menu
ModernFix
More Culling
Nvidium
Sodium

commented

Is that on a biome border?
Also which of those mods add content

commented

According to F3 both are minecraft:plains, there is a flower forest nearby but it doesn't tend to change on the biome border. All of the mods are client side optimization mods, they don't really add any content.

commented

Correction: Craftify is a mod that adds a Spotify GUI to the HUD, Bobby increases render distance on servers by chaching chunks, and Cubes Without Borders adds borderless fullscreen, the rest are optimization mods.

commented

Can I have the world file?

commented

It's >1GB, too big for github lol

commented

In that case-seed and coordinates?

commented

Seed: 2587887809679347605
Coords are in the screenshots, but those specific coords aren't bugged every time, they were until I relogged. But the bug has always been in the general vicinity of that village.

commented

I keep forgetting to check this out so i set a reminder. unfortunately I'm not home for another 10 hours or so

commented

Can't seem to reproduce by flying around in that village. Were you using any datapacks & also what was the game time when this issue occured?

commented

Hi!
I reported this a while back in SO discord with a test world where the problem can be reproduced.

Here it is: https://drive.google.com/file/d/1NZVJloTUNHnx2UheIJWn78VrPA8zkLUa/view?usp=sharing
Can replicate with only BadOptimizations installed with default config. To reproduce the bug, just wait when it's daytime.
2024-04-16_18 10 19

commented

Oh was it the one about the dark sky mod that was reported in the discord?

commented

I didn't use any dark sky mod then. It was SO without any additional mods, with sky bug caused by BadOptimizations.

commented

Where is the message in the discord? Can I have a link?

commented

Do you know the exact I should plug in to /time to reproduce the issue?

commented

You can just join the world and the bug would be here, its best visible at day, but reproduced right after world join

commented

Alright, I'll give it a try when I get home...hopefully.

commented

I can confirm this, it happens to me too

commented

why is the world so big...

commented

Is that a problem? I don't think less than 100mb is a lot...

commented

Oh it's not. I downloaded and was able to reproduce the issue.
Might fix it alongside 1.20.5.
If you couldn't tell, I'm quite hesitant to do anything with this mod-it isn't and was never my "main" project, basically a side project that happened to sort of blow up.

commented

I, for the life of me, cannot figure this out.
...I still need to get 1.20.5 out too.

commented

Seems like I just found the culprit of the crime.

commented

I swapped some stuff aroumd, I dunno, does this version solve the issue?
mod.zip

commented

The benchmark map no longer presents the problem, at least in the same location and time.

commented

So, issue solved? If so, don't close it until I release.

commented

I swapped some stuff aroumd, I dunno, does this version solve the issue? mod.zip

Sir, will this also apply to 1.20.1?

commented

Sir, will this also apply to 1.20.1?

Yes, I will backport the fix to all supported versions. This will also most likely be the final supported release for 1.19.3/1.19.4.

commented

Sir, will this also apply to 1.20.1?

Yes, I will backport the fix to all supported versions. This will also most likely be the final supported release for 1.19.3/1.19.4.

Oh, some people opened a "Remove BadOptimizations" bug report on SimplyOptimized modpack github page, so i wondered if it never gonna be applied into 1.20.1, thanks for giving us a nice mod!

commented

I will close it when it is fixed, don't worry :D

commented

So just to confirm-the modified I version I sent before has fixed the issue and I can mark this as complete and release?

commented

So just to confirm-the modified I version I sent before has fixed the issue and I can mark this as complete and release?

No :( let the new version be released with the fix first.

commented

???

commented

Is the issue fixed? If so I can add the other feature, port to other versions and release.

commented

Is the issue fixed? If so I can add the other feature, port to other versions and release.

They said it did so. idk

commented

So just to confirm-the modified I version I sent before has fixed the issue and I can mark this as complete and release?

Since the issue was never consistent on my world it's difficult to say with 100% certainty, but I've been playing with the modified version for a few hours and I haven't encountered it. It was pretty common before so it does seem to have been fixed yes.