BadOptimizations

BadOptimizations

18M Downloads

Darkness effect doesn't work as intended like in vanilla with this mod. [1.20.1]

PootisWizard opened this issue ยท 21 comments

commented

Hello.

I was playing around my world and I decided to get this mod (because I was getting optimization mods around this time), and I noticed one peculiar thing that happened with this mod, and only this mod.

I traveled down to a ancient city and when I set off the one of the sculk shriekers, I got the darkness effect; normally, this is suppose to cause a pulse-like effect (as stated in the accessibility options), dimming the brightness down to near darkness on and off, however, for some odd reason, and only with this mod, the effects of darkness doesn't work as intended like in vanilla.

There is no pulse-like effect, it just stays in "near darkness" till it wears off, this makes it incredibly annoying to travel down in darker areas, and be blinded by darkness (Light sources and dynamic lights counter this, albeit weakly).

Turning the darkness pulsing off in the options does fix this issue (or just, not on 100%), but I do miss the intended effect of the darkness effect with the pulse.

I suspect this might have to do with lightmaps? I could be wrong, as I don't know much about the technical side of Minecraft, but I thought I let you know about this weird bug only affecting this mod.

commented

BadOptimizations-2.2.1-dev-shadow.zip This one works, I think.

Good news! Minecraft does see this mod and register it!

The bad news:

Image

Tested with both my existing profile, and a new profile in the PrismMC Launcher

commented

Completely rewrote the buildscript:
BadOptimizations-forge-2.zip

commented

Completely rewrote the buildscript: BadOptimizations-forge-2.zip

I downloaded this version and tested it out as seen here, it seems that the darkness effect is really stubborn.

commented

Oh im an idiot, I fixed the buildscript but forgot to apply the darkness patch

commented

BadOptimizations-forge-2.tar.gz

Tested this just now, and it works!
Darkness effect pulses, whilst badoptimizations does what it does in the BG, now I don't have to worry about wardens anymore

commented

Yeah that is a lightmap issue. Hm, i thought i added special behavior for darkness.

commented

Does turning off the lightmap stuff fix it? If so, then that's what need a a fix

commented

Image

I have a small selection of mods (testing purposes) installed with BO (I took it off as I decided against including it in the final selection), and I'm unaware if any of the shown mods could override with the special behavior you mentioned, I am also using the PrismMC Launcher, if any of this helps you narrow out the problem.

commented
commented

Does turning off the lightmap stuff fix it? If so, then that's what need a fix

I have tested this right now, I assumed it was the "Enable_lightmap_caching" option, I set that to false, and that fixed the darkness behavior back to vanilla

commented

Yup, will need a fix for that.

commented

Nevermind you posted it

commented

I have tested out the one in the ZIP just now, and I can't tell if it does work because it seems this version doesn't make a config, nor use the pre-existing config from the published version.

As proof, BadOptimizations does not appear in the mods tab:

Image

commented

Image
Nevermind, i sent the wrong file

commented

Oops. You're on 1.20.1 right?

commented

BadOptimizations-2.2.1-dev-shadow.zip
This one works, I think.

commented

BadOptimizations.zip

I have downloaded the mod from here and tested it out, it does not appear in the mod list:

Image

For proof that I have it installed, it IS in the mods folder:

Image

Tested to see if it would make a config file, and use a pre-existing config, but Minecraft doesn't seem to register it as a installed mod.

commented

Ok, github has to be messing with me or something. I uploaded the right JAR file and its replacing it with a dummy jar with no files.

commented

published as 2.2.2