Crash

Question

Crash

Closed this issue 5 months ago · 9 comments

RaKGEKKO commented 5 months ago

I found a crash when i pair BadOptimizations with Lazyyyyy related to the entity type caching option, if i disable this two options it doesn't crash.

enable_entity_renderer_caching: false
enable_block_entity_renderer_caching: false

Here is the log and crash report in case they are necessary.

crash-2025-04-25_20.45.11-client.txt
latest.log
https://mclo.gs/zOWzFa4

RaKGEKKO commented 5 months ago

Thx!

imthosea · Answer 1 · 2025-04-28T01:41:42.000Z

give this a shot: BadOptimizations-2.2.1-1.20.zip

RaKGEKKO · Answer 2 · 2025-04-28T06:34:07.000Z

Tysm! it works without crashing now.

imthosea · Answer 3 · 2025-04-29T01:32:56.000Z

published as 2.2.2

SettingDust · Answer 4 · 2025-04-29T02:41:57.000Z

Relate: SettingDust/lazyyyyy#59

SettingDust · Answer 5 · 2025-04-29T02:43:34.000Z

For curious. Why the compat I added before isn't working every time.

https://github.com/SettingDust/lazyyyyy/blob/main/xplat/src/main/kotlin/settingdust/lazyyyyy/LazyyyyyMixinPlugin.kt#L103-L116

imthosea · Answer 6 · 2025-04-29T02:48:49.000Z

Oh gosh, I didn't realize people actually used this as an API. If this becomes before common I may add system properties to make it less cursed.

Anyhow, I believe it has something to do with priorities - what comes first in the log, BadOptimizations loading config or the disabling message?

SettingDust · Answer 7 · 2025-04-29T02:52:24.000Z

Not quite sure. I've delayed the compat code from onLoad to apply xddd.

I have two mixin config using this mixin plugin. So, twice log

imthosea · Answer 8 · 2025-04-29T10:34:35.000Z

Hm odd. Maybe the mixin plugin is being evaluated before yours disable it? Could try rebuilding BO with print statements in the mixin plugin when a config option is actually being used

Share to