Greetings Lord Dusk,

I was doing some mining today and noticed some quirks with my bagginses. I have 3 plus 1 ender baggins. Two were set to pickup mode.

• Pickup mode only worked when the bag was in the 1st hotbar slot. (I've since read that you're supposed to have it in your off-hand, so there y'go). I note that the config item reads "enable for bags in your hotbar". Should this be working for all slots?

• Bagginses don't always stack items correctly. Several times when cleaning out the junk, I noticed that I had more than one incomplete stack of the same type of ore.

• The range and speed of the pickup is nothing short of miraculous. I see no config option for the range. In addition to lowering the default range, a config option would be nice. Also (and it's minor) I'm not a fan of the instant teleportation of items into the bag. I feel a magnet-style attraction would be better, if you're bored and feel like implementing new functionality :)

• Finally a request, to be able to add a filter to the pickup mode. Whether it voids such blocks, or simply leaves them floating is not that important. It would be nice to, for example, whitelist cobble/andesite/etc on one bag and blacklist them on another, and have both bags function concurrently in pickup mod.

Cheers!

Hello, I'm the current dev at the moment while Dusk is busy with real life.

• The pickup slot was something I had been experimenting with and I don't think I ever correctly documented. It currently works for offhand and all the hotbar slots (Priority going offhand then slots 1 -> 9). What is your view on how it should work? Should I add a more detailed config option to allow just offhand or hotbar?
• As for the stacking issue, I hadn't noticed this during my testing. I'll take another look at the code and see if I can improve the method for attempting to stack items together
• The range and speed was something I struggled to find a good method of managing it when I first looked at it. Currently any drops/blocks mined by the player while a bag in Pickup mode is equipped are automatically added to the bag, regardless of range. I agree it could do with some tweaking and I'll take a look at how other people have implimented magnets to see what I can come up with
• The filter was something I had been wondering about myself. I was thinking perhaps something along the lines of the Extra Utilities filters that could be added to bags. I had thoughts about just adding filter options to the void bag, so you could void the useless stuff and everything else would be picked up.

As a note this has also reminded me that I don't think I do any checking of the config whitelist/blacklist when auto picking up items into bags. This needs to be implemented too at some point.

Thank you very much for the comments and I'll do my best to see what I can add 👍

Howdy,

My two pickup bags were in hotbar slots 1 & 2 but only the bag in slot 1 was picking up. When bag 1 was full, the items it couldn't suck up were just left floating, even though there was room in bag 2. That's why I found myself clearing out the junk all the time :-) So you may have a bug there. I didn't test with the off-hand since I didn't know that was an option. I can do so if you would like.

I feel that it should work as you described. All hotbar slots and the off-hand and the priority you mentioned sounds fine. Config options to limit that would be nice as it'd give folks and pack devs the opportunity to make it a little more restrictive. I wouldn't bother with really detailed config. I think 1/2/3 (All, off-hand only, hotbar only) should suffice.

The reason I noticed the range/speed issue is because I was mining with Psi which has a range of 32 blocks. So I was quite far from where I was mining, yet the blocks still magically arrived in my bag. As much as I made full use of the extraordinary range, I know that some people will find it excessive :) Something similar to Botania's magnet ring and EnderIO's electromagnet would be good.

The xu2 filters are what I was thinking of :) If you go the route of just filtering the void bag, you'd need to have it's Pickup have priority, otherwise you'll have junk winding up in the other bags. Users won't remember to put the void bag in the off-hand and "loot" bags on the hotbar. Alternatively, have it that way as a feature! (But document it well so to reduce issues being logged!)

Another option might be to ditch the void bag completely and have two filter slots; one for a void filter and one for a regular filter. Again, having the presence or absence of those filter slots might be worth putting in the config file.

Regardless of how you handle voiding, I'd like to see a whitelist filter on bags so that I can have (for example) ores going into bag 1, gems into bag 2, etc.

Thanks for your work on this mod. We love you!

Cheers