Balm (Fabric Edition)

Balm (Fabric Edition)

Mods
27M Downloads

[1.21.1] Intermittent startup crashes

Shadows-of-Fire opened this issue ยท 1 comments

commented

Minecraft Version

1.21.1 (LTS)

Mod Loader

NeoForge

Describe the Issue

Balm appears to have a race condition in the BalmClientRuntimeSpi that only presents with very high concurrency levels (I'm using a 16c/32t CPU, others in the same pack with lower-core CPUs are not hitting it as frequently or at all).

The relevant stack trace is:

java.util.NoSuchElementException: No value present
	at java.base/java.util.Optional.orElseThrow(Optional.java:377) ~[?:?]
	at TRANSFORMER/[email protected]/net.blay09.mods.balm.api.client.BalmClientRuntimeSpi.create(BalmClientRuntimeSpi.java:11) ~[?:?]
	at TRANSFORMER/[email protected]/net.blay09.mods.balm.api.client.BalmClient.initializeRuntime(BalmClient.java:78) ~[?:?]
	at TRANSFORMER/[email protected]/net.blay09.mods.balm.neoforge.client.NeoForgeBalmClient.onInitializeClient(NeoForgeBalmClient.java:10) ~[?:?]
	at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.ConsumerEventHandler.invoke(ConsumerEventHandler.java:26) ~[bus-8.0.2.jar:?]
	at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.EventBus.post(EventBus.java:350) ~[bus-8.0.2.jar:?]
	at MC-BOOTSTRAP/net.neoforged.bus/net.neoforged.bus.EventBus.post(EventBus.java:315) ~[bus-8.0.2.jar:?]
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.ModContainer.acceptEvent(ModContainer.java:158) ~[loader-4.0.38.jar:4.0]
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.ModLoader.lambda$dispatchParallelEvent$4(ModLoader.java:172) ~[loader-4.0.38.jar:4.0]
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.ModLoader.lambda$dispatchParallelTask$7(ModLoader.java:231) ~[loader-4.0.38.jar:4.0]
	at java.base/java.util.concurrent.CompletableFuture.uniHandle(CompletableFuture.java:934) [?:?]
	at java.base/java.util.concurrent.CompletableFuture$UniHandle.tryFire(CompletableFuture.java:911) [?:?]
	at java.base/java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:483) [?:?]
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387) [?:?]
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312) [?:?]
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843) [?:?]
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808) [?:?]
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188) [?:?]
[23Mar2025 18:26:02.848] [modloading-worker-0/FATAL] [net.neoforged.fml.ModLoader/LOADING]: Failed to wait for future Sided setup, 1 errors found

Balm version is balm-neoforge-1.21.1-21.0.35

Logs

https://gist.github.com/Shadows-of-Fire/cac31f6ab796a489dfcaaafb879b16ca

commented

No idea how that could possibly happen but should be fixed in 21.0.36