Balm (Fabric Edition)

Balm (Fabric Edition)

27M Downloads

Possible wrong custom stat registration?

Closed this issue ยท 1 comments

commented

Minecraft Version

1.21.10

Mod Loader

Fabric

Describe the Issue

Joining a server on old Balm with a client on new Balm complains about custom stats from the server being unknown and they are shown as part of the minecraft namespace which is weird. Not sure if the old version was broken or the new one is, or if it's just an issue in the backwards compat.

Logs

[10:56:51] [Render thread/ERROR]:
Received unknown remote registry entries from server
[10:56:51] [Render thread/ERROR]:
Registry entry (minecraft:dig_spots) is missing from local registry (minecraft:custom_stat)
[10:56:51] [Render thread/ERROR]:
Registry entry (minecraft:fishing_spots) is missing from local registry (minecraft:custom_stat)
[10:56:51] [Render thread/ERROR]:
Registry entry (minecraft:gold_rushes) is missing from local registry (minecraft:custom_stat)
[10:56:51] [Render thread/ERROR]:
Registry entry (minecraft:drop_rushes) is missing from local registry (minecraft:custom_stat)
[10:56:51] [Render thread/ERROR]:
Registry entry (minecraft:waystone_activated) is missing from local registry (minecraft:custom_stat)

commented

It was an issue in the old FabricBalmStats implementation, where it was registering the stat in the default namespace by passing a String name instead of ResourceLocation name:

Registry.register(BuiltInRegistries.CUSTOM_STAT, identifier.getPath(), identifier);

New version is correct, bumping network version to prevent odd errors when using mismatched versions.