Bamboo Blocks

Bamboo Blocks

6M Downloads

Bamboo Torch Crash

WenXin20 opened this issue ยท 3 comments

commented

Minecraft v1.16.5
Forge v36.2.4
Abnormals Core v3.3.0
Bamboo Blocks v3.0.0

After placing down the Bamboo Torch in the nether, the game crashed.
Crash Report

commented

Game crashed aswell when placing torch in overworld:
crash-2021-09-29_20.33.45-client.txt

commented

These crashes are likely to keep happening from time to time, since Bamboo Blocks sometimes passes in null to a vanilla function that shouldn't have null parameters passed into it: https://github.com/team-abnormals/bamboo-blocks/blob/main/src/main/java/com/minecraftabnormals/bamboo_blocks/common/block/BambooTorchBlock.java#L109

We added a null check in Valhelsia Structures a while back because of this, but ultimately it shouldn't have been needed since the IBlockReader parameter shouldn't have been null anyway (although it's always good to have safety checks for when mods aren't doing what they should, which is why we didn't mind adding it).

This time I think it might be Supplementaries triggering the issue, but again, the IBlockReader shouldn't be null so MehVahdJukaar adding a check there would be more of a band-aid that is likely to only fix the issue temporarily until another mod does the same thing: https://github.com/MehVahdJukaar/Supplementaries/blob/master/src/main/java/net/mehvahdjukaar/supplementaries/mixins/AbstractBlockMixin.java#L21

commented

well idk how a null value is ending up in there but I did add that null check just to be sure. Still should probably be changed since that doesn't seem to be a nullable parameter