default behavior will break your bed
fw4hre0xxq opened this issue ยท 7 comments
How to reproduce
Add your steps to reproduce the issue/bug experienced here.
Currently (Baritone 1.2.11) if you are doing a path or mine command, and you die and respawn, baritone will break your bed. This is most easily observed if your bed is underground or in an enclosed space. The same thing can happen if you are returning to a waypoint set near the bed.
I am going to file a pull request for this. This issue is just to add tracking and context.
Final checklist
- I know how to properly use check boxes
- I have included the version of Minecraft I'm running, baritone's version and forge mods (if used).
- I have included logs, exceptions and / or steps to reproduce the issue.
- I have not used any OwO's or UwU's in this issue.
You seem to have forgotten how to tick checkboxes. GitHub/Markdown checkboxes can be used to keep track of tasks or to create a checklist of requirements that need to be fulfilled whilst writing, for example, an issue. This can be achieved through writing a text similar to this:
- [x] Hello, fulfilled requirement!
- [ ] Hello, unfulfilled requirement!
The above example will turn into this:
- Hello, fulfilled requirement!
- Hello, unfulfilled requirement!
What you might have observed is that the x
between [
and ]
indicates that the task has been fulfilled, compared to an unfulfilled task without x
. There's no room for further spaces (meaning - [ x]
and - [x ]
is invalid).
https://gitlab.com/CDAGaming/fabritone/-/commit/2681ee258c9792b5d49cab2c87cec21093332bd6 is a more accurate fix for this covering all versions and even modded variants extending the Base Block.
https://gitlab.com/CDAGaming/fabritone/-/commit/29d16a608423c8fff8fd3e3bfafd1cbc0c0462b6 was also done to add FernBlocks to this adjustment as well to save durability.
Both can be cherry-picked at discretion of @fw4hre0xxq or any existing Baritone dev to resolve and close this issue.
I think while we're at this we should consider expanding the default list. The list I use is crafting_table,furnace,lit_furnace,chest,trapped_chest,standing_sign,wall_sign,bed,farmland,hopper,unpowered_comparator,powered_comparator,redstone_block,unpowered_repeater,powered_repeater,dispenser,dropper
.
I wonder why baritone would break fern blocks since they're non-solid. I'm thinking that could be a separate issue.
FernBlocks became mostly an issue with Fabritone but seeing as they should be avoided anyways, i put that on the default list too.
@CDAGaming Aren't ferns non solid blocks, and therefore ought be walked through by baritone instead of broken?
Apparently Fabric doesnt think of them as the same way, though looking at it deeper Ferns may actually be considered solid as Baritone does consider everything solid due to AABB -> Shape Changes in 1.15.x that cause this, hence why Ferns are blocked in default now to preserve default behavior