Baritone AI pathfinder

Baritone AI pathfinder

72.7k Downloads

Water is not picked up after Bucket Fall

x4e opened this issue · 3 comments

commented

Some information

Minecraft version: 1.12.2
Baritone version: standalone-forge-1.2.14

Exception, error or logs

Nothing is written to log

How to reproduce

Start a path that involves a water bucket fall
Water bucket will not be picked up

This does not occur 100% of the time, sometimes it is picked up. I've noticed this while travelling in the end. I didnt notice any pattern that would hint why it would/wouldnt be picked up.

After looking at the code (

if (InventoryPlayer.isHotbar(ctx.player().inventory.getSlotFor(STACK_BUCKET_EMPTY))) {
) my guess is that the server doesn't update the inventory fast enough depending on ping/tps. Perhaps you could assume that unless the player is in creative, the bucket will be empty server side even if not client side, and therefore the water should be picked up.
Or perhaps when the Right Click button is set to true, we are no longer looking at the water, and therefore it fails?

Modified settings

None

Final checklist

  • I know how to properly use check boxes
  • I have included the version of Minecraft I'm running, baritone's version and forge mods (if used).
  • I have included logs, exceptions and / or steps to reproduce the issue.
  • I have not used any OwO's or UwU's in this issue. <- My religion does not allow me to tick this.
commented

I'm pretty sure this is due to the distance speed calculation being unreliable and baritone deciding it's safer to just not

commented

I’m not entirely sure what you are referring to when you say “distance speed calculation”

commented

there's a comment in the code somewhere mentioning how unreliable distance calculations are for water buckets when picking it up