Baritone AI pathfinder

Baritone AI pathfinder

72.7k Downloads

Baritone compatibility error with Wurst

7Xx9XrPn1B opened this issue · 5 comments

commented

Some information

Operating system: Windows 10 Pro (64-bit)
Java version: 8 Update 291 (64-bit)
Minecraft version: Fabric 1.16.5
Baritone version: api-fabric-1.6.3 (1.16.5)
Other mods (if used): Used Wurst-Client-v7. 15-MC1. 16. 5

Exception, error or logs

latest.log

How to reproduce

  1. Install Fabric mod Wurst-Client-v7. 15-MC1. 16. 5 and baritone-api-fabric-1.6.3
  2. Enter the #help command in the chat.
  3. Click on any clickable text.

Modified settings

The settings do not affect the error.

Final checklist

  • I know how to properly use check boxes
  • I have included the version of Minecraft I'm running, baritone's version and forge mods (if used).
  • I have included logs, exceptions and / or steps to reproduce the issue.
  • I have not used any OwO's or UwU's in this issue.
commented
  1. there are invalid characters in that bug report
  2. wurst does not cause that
commented

and yet I was able to reproduce this,

https://github.com/Wurst-Imperium/Wurst7/blob/dbbae665d0bada450b457fb4cb0118a3c1886939/src/main/java/net/wurstclient/mixin/ScreenMixin.java#L40
and

private void sendChatMessage(String msg, CallbackInfo ci) {

conflict, specifically when clicking on the baritone chat stuff.

commented
  1. wurst does not cause that

looked at the files @wagyourtail mentioned and I think this is indeed caused directly by wurst and not a mixin conflict. Wurst just cancels the method and sends the message itself instead of allowing the vanilla behaviour (or Baritone, which hooks in slightly later than wurst) to happen.

So unless someone proves me wrong this can be closed and should be reported on the wurst bug tracker instead.

commented

oh wait my client uses a similar mixin, that’s why that bug occurs for me too

commented

I'm now pretty sure this is not a Baritone error but a Wurst error and should be reported on their bug tracker accordingly.
I think we could try moving Baritones injection point to an earlier point, but as far as I know (and that's not much for mixins) that would only make it depend on the order of mixin application instead of fixing it reliably.