Baubles

Baubles

117M Downloads

Baubles don't sync to other players

Vazkii opened this issue ยท 5 comments

commented

Other players in the server don't know which baubles are equipped which causes some desync on some cases.

commented

Yup, I only keep it synced between server and client for the client wearing it only. What do you require it to be synced between player clients for? Visual effects?

commented

If you wanted to render something on the player depending on the Baubles they're wearing, this would be pretty important.

commented

You wouldn't have to send any data if no baubles are equipped. Other than that, if you only send when changes happen / when players start seeing each other, it shouldn't be an issue.

commented

I've been going back and forth about it since my last comment and I have came to the same conclusion. Its not that a huge amount of data and I might want to do similar visual stuff for TC at some point.

Okey dokey, closing this then. Next update should have this.

commented

I agree, but I think it is a bit outside the scope of what the mod provides. I don't like the idea of sending sync packets to all players just in case someone wants to use that data clientside. I feel it is up to the individual mod/bauble to do any required syncing.

However, I am willing to be convinced. :)

EDIT: the change itself is about 2 lines of code so that is not the issue - I'm just looking for compelling reasons for the extra network traffic.