[Bug] Nullscape biomes not generating on new worlds
quiqueck opened this issue ยท 2 comments
What happened?
When creating a new world with Nullscape (mod-version installed) the fresh world will not generate any Nullscape Biomes.
Closing an reentering the world will load the biomes as intended.
BCLib
2.0.10
Fabric API
0.57.0
Fabric Loader
0.14.8
Minecraft
1.19
Relevant log output
No response
Other Mods
No response
The same issue can be reproduced with just FAPI and Nullscape installed:
- Go to the "Create New World"screen
- Open "More World Options..." Page
- Click the "World Type"-Button until you get back to the Default World Type (the important thing is, that the world type got changed to something that is not Default once).
- Create the world
After this sequence, no Nullscape Biomes will generate.
As far as I can tell the issue is related to CreateWorldScreen.openFresh. This will create the initial WorldGenSettings for the default World Type. This code does include settings provided by other Mods. However, when clicking the World-Type Button those WorldGenSettings get loaded in a way, that does not include data from Mods.
BCLib uses a Mixin to that method in order to make the BetterX-Worldtype the default. Which is basically destroying the only correct only version of the WorldPreset that was loaded correct. If players change the World Type back to Default with BClib installed, the vanilla Default biome Settings get loaded, which will not include the Nullscape Biomes.
The underlying bug (WorldGenSettings are not properly loaded) may also be the cause for #19.