I found 2 problems at once
Willem07 opened this issue ยท 3 comments
The first problem
When you put blinds of different types, then you open them, then the rest turn into the blinds that I opened first
The second problem is the translation of some items
Some items that I translate into another language break the description
When an item has an English name, the description works correctly
Some items work correctly with the name and description, and some do not
forge 1.20.1
beautify-2.0.1
You can try a new translation
Beautify
Thank you for reporting these issues and especially the translation!
When you put blinds of different types, then you open them, then the rest turn into the blinds that I opened first
The Blinds-Bug was actually an error that resulted from the rework of the structure of the mod. Previously, because I was inexperienced, I created classes for every blind-type. After the rework, there was only one base-class. That however broke the sameBlindType
check that was comparing classes instead of instances.
sameBlindType
now compares 2 instances instead of the class to itself
Some items that I translate into another language break the description
When an item has an English name, the description works correctly
Some items work correctly with the name and description, and some do not
The language keys were composed of the Item's name and a suffix. I haven't thought of the issue that Item's names would also change between languages instead of representing the internal names.
- Language Keys in
appendHoverText
are now hard-coded to prevent this issue
You can try a new translation
Thank you, I've added the ru_ru.json
to the fix I'll be pushing soon.
Once I've fixed enough, I'll credit you in the changelogs. If I don't remember, please remind be :)
- Added
ru_ru.json
to thelang
folder
I would also like to backport fixes as in the fabric version
Also, I'll take a look at the fixes for fabric asap!
I have corrected some names, in future updates you can overwrite it.
update lang