biomeselector 'type' not working with 'desert' biome specification
esotericist opened this issue · 5 comments
Sorry to be flooding the issue tracker, but I'm exploring the mod and trying to get it to behave how i want, and that's resulting in a lot of 'I'm not sure this is right'. :)
I added the thermal foundation fluid ores in a config file, like so:
[
{
"state": {
"name": "thermalfoundation:ore_fluid",
"properties": {
"type": "crude_oil_gravel"
}
},
"biomeSelector": "type",
"biome": "desert",
"weight": 30,
"widthMin": 3,
"widthMax": 12,
"countMin": 7,
"countMax": 20,
"yieldMin": 100,
"yieldMax": 500,
"extractionCooldownScale": 5,
"groupOrder": "thermalfoundation"
},
{
"state": {
"name": "thermalfoundation:ore_fluid",
"properties": {
"type": "redstone"
}
},
"weight": 3,
"widthMin": 3,
"widthMax": 6,
"countMin": 8,
"countMax": 12,
"yieldMin": 100,
"yieldMax": 150,
"extractionCooldownScale": 5,
"groupOrder": "thermalfoundation"
}
]
There were no reports of parsing errors on this file in the log, but when I check the output of /bedrockores info I get:
[22:32:18] [main/INFO]: [CHAT] §aAll ores we may embed in bedrock in dimension §r0§a (type: §roverworld§a), biome §rminecraft:desert§a (types: §r?§a):
[22:32:18] [main/INFO]: [CHAT] §7 - §fabyssalcraft:nitreore
[22:32:18] [main/INFO]: [CHAT] §7 - §fdeepresonance:resonating_ore[oretype=overworld]
[22:32:18] [main/INFO]: [CHAT] §7 - §fimmersiveengineering:ore[type=aluminum]
[22:32:18] [main/INFO]: [CHAT] §7 - §fimmersiveengineering:ore[type=uranium]
[22:32:18] [main/INFO]: [CHAT] §7 - §fminecraft:diamond_ore
[22:32:18] [main/INFO]: [CHAT] §7 - §fminecraft:gold_ore
[22:32:18] [main/INFO]: [CHAT] §7 - §fminecraft:iron_ore
[22:32:18] [main/INFO]: [CHAT] §7 - §fminecraft:lapis_ore
[22:32:18] [main/INFO]: [CHAT] §7 - §fminecraft:redstone_ore
[22:32:18] [main/INFO]: [CHAT] §7 - §fthermalfoundation:ore[type=copper]
[22:32:18] [main/INFO]: [CHAT] §7 - §fthermalfoundation:ore[type=lead]
[22:32:18] [main/INFO]: [CHAT] §7 - §fthermalfoundation:ore[type=nickel]
[22:32:18] [main/INFO]: [CHAT] §7 - §fthermalfoundation:ore[type=silver]
[22:32:18] [main/INFO]: [CHAT] §7 - §fthermalfoundation:ore[type=tin]
[22:32:18] [main/INFO]: [CHAT] §7 - §fthermalfoundation:ore_fluid[type=redstone]
The crude gravel ore does show up under /bedrockores list, so it's clearly getting picked up, but 'info' doesn't seem to think it should spawn in a desert biome. Near as I can tell, no bedrock ores of that type spawned, either (by way of using a 'scannable' block module dialed to oil shale)
Allright, sorry for the delay, it's in now; biomeSelector now also accepts dictionary. Current biome dictionary types are now also listed in the /bedrockores info command.
That's what I ended up going with, yeah.
Any chance you could maybe add biome dictionary support? That's what I originally assumed the 'type' selector was meant to be.
That's a thing? After years of modding, you learn something new every day... I'll look into that!
(Though for compat it'd be a new type, 'dictionary' or so.)
Your selector requires one of the biome's types to be desert. Which, amusingly enough, the vanilla desert biome doesn't appear to be (notice the "types: ?" after the biome name, the question mark means the biome has no known types). No idea if that's a vanilla or Forge bug or by design.
Anyway, what you'll need to do instead is use the id based filter and add "minecraft:desert" to the list of biomes. And any other desert biomes in your modpack you want that to spawn in.