Translation for advancement criteria names

Question

Translation for advancement criteria names

Strubbelkopp opened this issue 2 years ago · 10 comments

Strubbelkopp commented 2 years ago

It would be nice to have the ability to change the internal names of advancement criteria thorugh a config or a language file as suggested in this issue from AdvancementInfo

Leronus commented 2 years ago

+1

jhmaster2000 · Answer 1 · 2022-10-30T06:03:56.000Z

+1, I've just closed my linked issue on AdvancementInfo after finding out the author of that mod is not interested in adding new features so it'd be nice to have this mod replace it.

WondaMegapon · Answer 2 · 2023-04-12T17:16:03.000Z

+1

I'm a complete novice to Fabric, but it seems like just getting lines 99, 107, and 117 in CriterionGrid.java to use translatable tokens would be more than enough to achieve this effect. The only issue would be getting those tokens in the first place. 😮

Darkosto · Answer 3 · 2024-06-13T20:52:02.000Z

Hey @way2muchnoise ! Is there any chance that you'd be willing to look into this? I'd love to have more accessibility for players by allowing translatable criteria. Thank you for the mod and keep it updated! <3

way2muchnoise · Answer 4 · 2024-06-17T18:34:52.000Z

Thanks to @GoryMoon you can now add translations keys as follows:
betteradvancements.criterion.<advancement id>.<criterion name>
Full details in the PR: #165 (comment)

Darkosto · Answer 5 · 2024-06-17T19:44:26.000Z

Sorry to be a bother @way2muchnoise but is there any way you'd be able to push that update to 1.20.1? I'm unable to move my project up to 1.20.4 without starting over on most of it. If not, no worries and thanks for your help!

way2muchnoise · Answer 6 · 2024-06-17T20:38:49.000Z

Will backport it 😃 just give me some time. Hope to get to it in the weekend

Darkosto · Answer 7 · 2024-06-17T20:40:54.000Z

Thank you so much! You're the best! ❤️

way2muchnoise · Answer 8 · 2024-06-21T18:53:43.000Z

@Darkosto Thanks to @GoryMoon, we have full back port to 1.20.1 (#167)

bravely-beep · Answer 9 · 2024-12-17T13:05:59.000Z

It would be good if we could specify an existing translation key to use for a criterion, rather than having to create a new one. To use the example in the PR comments,

"betteradvancements.criterion.minecraft:adventure/adventuring_time.minecraft:beach": "Beach"

would require duplicating the translation of the biome name for every language, when biome name translations already have vanilla translations.

Ideally this would be implemented as an additional datapack field, e.g. data/minecraft/advancements/adventure/adventuring_time.json could contain

{
    "criteria": {
        "minecraft:beach": {
            "translate": "biome.minecraft.beach"
        }
    }
}

Share to