null check in the soaring winds artifacts enchantment
munstarz opened this issue · 5 comments
caused crash during liftoff
This part of the code should only be called if you have Trinkets installed. I assume you have installed it, otherwise please tell me because that means there is a different issue here.
There is a null reference where there shouldn't be one - anyway: it is my fault for not doing a safety check there.
Does this error come up every time you are using an Elytra with Soaring Winds, or does this only happen occasionally?
Hello:
I do have trinkets installed. Thanks for letting me know about it! It was only triggered when I try to take off using an elytra. I didn't use an elytra with said enchantment ever after that, I am not entirely sure if I try to do so again would it also cause a crash. Anyways, thank you for the reply.
Munsters
…------------------ Original ------------------
From: ***@***.***>;
Date: 2024年7月13日(星期六) 晚上11:35
To: ***@***.***>;
Cc: ***@***.***>; ***@***.***>;
Subject: Re: [Pandarix/BetterArcheology] null check in the soaring winds artifacts enchantment (Issue #79)
This part of the code should only be called if you have Trinkets installed. I assume you have installed it, otherwise please tell me because that means there is a different issue here.
There is a null reference where there shouldn't be one - anyway: it is my fault for not doing a safety check there.
Does this error come up every time you are using an Elytra with Soaring Winds, or does this only happen occasionally?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
I added a null and additional safety checks to be safe.
I've had a lot of personal business due to uni lately, but now I have time to release a new version including this fix soon :). Please be patient
Hey:
Please take your time~ the mod is working quite fine without the elytra too!
Good luck on exams and studies and thanks Xoxo.
Jiawen
…------------------ 原始邮件 ------------------
发件人: ***@***.***>;
发送时间: 2024年7月25日(星期四) 凌晨1:13
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [Pandarix/BetterArcheology] null check in the soaring winds artifacts enchantment (Issue #79)
I added a null and additional safety checks to be safe.
I've had a lot of personal business due to uni lately, but now I have time to release a new version including this fix soon :). Please be patient
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
