Better Builder's Wands

Better Builder's Wands

89M Downloads

Client crash when looking at Torchmaster torch

A-bac opened this issue ยท 1 comments

commented

Hi, developer of Torchmaster here. I've taken a closer look into this issue since it was reported on my repo as well (obviously).
As of now, I dont think the issue is on my side.
The mods used to replicate:

  • NetherEx 1.10.2-1.1.0b
  • BetterBuildersWands 1.10.2 0.11.1.220+f8232fe
  • Torchmaster 1.2.2.25
  • Forge 12.18.3.2185

To reproduce the crash, place down a mega torch and a netherrack block from the netherex mod.
Take a BetterBuildersWand (i tried the diamond one) and look at the netherrack block, then move the mouse over to the torch.

The crash happens, because the netherex mod trusts the data passed to getPickBlock() and returns a new itemstack without checking if the block at the given position is an actual netherex:netherrack block.
See: https://github.com/LogicTechCorp/NetherEx/blob/4822329731bab70d13e95d69d9347caab058e19f/src/main/java/nex/block/BlockVariantContainer.java#L55
It seems, the mod author no longer uses the BlockVariantContainer class but never released an update for 1.10.2. There is another class that uses the same getPickBlock() logic which would also cause this error.

I'll keep the issue open on my repo for now, but I dont think this issue is related to torchmaster itself.

Edit:
I was able to replicate the problem with a vanilla minecraft torch and the netherex netherrack. It seems the WandWorker#getProperItemStack() (or anything that calls it) doesnt handle Non-Full-Blocks that well.