Better Combat [Fabric & Forge]

Better Combat [Fabric & Forge]

25M Downloads

Problem using with Shield Expansion

Dr-WeiAL opened this issue ยท 7 comments

commented

Minecraft version - 1.18.2
Mod loader - Forge
Mod version - 1.6.2
I am using the latest version available - yes

Describe the bug
When used with Shield Expansion, raising the shield and using weapon attacks will keep the shield on cooldown unless you press and hold the right button until the shield is cooled down
infernalstudios/Shield-Expansion#23

To Reproduce
Steps to reproduce the behavior:
1.Shield in the left hand, sword in the right
2.Press and hold the right button to use the shield
3.Left click while using shield to use weapon to attack
4.Do not perform any operations
5.The shield will always be on cooldown

Expected behavior
Shields should not be on cooldown all the time

Screenshots or video recordings
image

Additional context
Add any other context about the problem here.

commented

Hello!
It would be nice to get some feedback on this from tinytransfem!
Maybe this is due to some state handling in Shield Expansion.

commented

infernalstudios/Shield-Expansion#23 (comment)
Well... that's what tinytransfem says

commented

Does this issue still require action from my side?

commented

Uh... the other side said it would be fixed in the next update, but it hasn't been updated until now, so it's better to fix it from this side?

commented

It looks like the issue is in the internal state of Shield Expansion logic. (I might be wrong)
I don't see any possible ways to fix this from my end.

commented

As far as I see, they could fix it by using Better Combat API.
Specifically BetterCombatClientEvents.ATTACK_START event. Hooking to this event would allow them to cancel shield blocking, or perform whatever is correct.

commented

Feel free to reopen in case it turns out that action is required from me.