Better Combat [Fabric & Forge]

Better Combat [Fabric & Forge]

25M Downloads

Cannot interact-use tools when attack speed is 0

Dr-WeiAL opened this issue · 8 comments

commented

Minecraft version - 1.20.1
Mod loader - Forge
Mod version - 1.8.5
I am using the latest version available - yes

Describe the bug
In Vanilla, even with an attack speed of 0, you can still use the weapon to open containers or throw them, but none of the above behaviors can be done when using BetterCombat.
This can lead to not being able to interact with anything with a lot of weapons after some other mods have reduced the player's attack speed
Enchantments that reduce attack speed but add throwing damage will also not work

To Reproduce
Steps to reproduce the behavior:

  1. Reduces your attack speed to 0 (e.g. Curse of Pandora's Charm Of Heavy Weapon)
  2. Holding a weapon with an attack speed of 1 in your hand (e.g. a trident)
  3. At this point you won't be able to open containers and throw tridents

Expected behavior
It seems to be because you can't do the above behavior until the attack cooldown is complete, can that be fixed?

Screenshots or video recordings
image

Additional context
Add any other context about the problem here.

commented

Attack speed means how many attacks per second can be done with full damage.
The attribute value equaling 0 is meaningless.

commented

hmm... Maybe I didn't express myself clearly, heavy weapons here, such as tomahawks, hammers, and the like, are not affected by the reduced attack speed, meaning that holding other weapons or tools is 0 attack speed, but holding a heavy weapon is 0.7 or higher, limiting the types of weapons that can be used while wearing that gear, but when installing a bettercombat, holding other tools can't be interact, which can cause a lot of inconvenience on a daily basis

commented

Can you provide some video footage or screenshots to better understand the problem!

commented

Vanilla
PixPin_2024-08-07_23-40-19
BetterCombat
PixPin_2024-08-07_23-43-39
That's probably it

commented

I am sorry I still dont understand the issue.

Also, any content that uses ADDITION entity attribute modifier has a chance to produce non sense attribute value. Attack speed should only be modified as MULTIPLY.

commented

I'm the dev of CurseOfPandora. It's intended behavior for players to not be able to attack when they wear that charm, unless they hold weapons that has more than 2 attack speed.

The question here is probably why players can't use right click with 0 attack speed.

commented

recording
recording
It's like the above, as long as it's recognized as a weapon by BetterCombat, you can't right-click to do anything while the attack speed is 0

commented

Thank you for the clarification.

I will investigate when I can.