Better Combat [Fabric & Forge]

Better Combat [Fabric & Forge]

35M Downloads

Compatibility with CombatRoll, rolling causing invisible attacks

gabuly opened this issue ยท 2 comments

commented

I read project readme, checked client side and server side configurations, and no such feature exists - YES

Is your feature request related to a problem? Please describe.
if you attack and immediately roll after, you will still be processing the attack action but without the animation, causing the visually invisible attack (hit and damage calculation etc all remain the same), so ultimately it seems like a bug if you attack and roll visually.

Describe the solution you'd like
I have spend some time checking the source code trying to find a method of cancelling current attack, only thing I found similar is cancelWeaponSwing but its pricate so I am not sure. I think this issue should be solved and could be solved by calling the cancelling method inside the tryRoll

Describe alternatives you've considered

Additional context

commented

More specifically, its the problem of upswing. If you roll during upswing, you will still perform the lateral attacks without animation. So what I can currently think of is to block roll key input during upswing...

commented

Released with 2.1.0