Better Combat [Fabric & Forge]

Better Combat [Fabric & Forge]

35M Downloads

Incompatibility with Sophisticated Backpacks - Offhand Refill deletes offhand items when swapping to two handed weapons

Closed this issue ยท 1 comments

commented

Minecraft version - 1.21.1
Mod loader - NeoForge 21.1.190
Mod version -
Sophisticated Backpacks: 3.24.17.1274
BetterCombat: 2.2.4
I am using the latest version available - Yes

Describe the bug
When using BetterCombat (and a two handed weapon, so SimplySwords required), the Advanced Refill upgrade in Sophisticated Backpacks in "offhand refill" mode will conflict and cause the offhand item to be destroyed.

To Reproduce
Steps to reproduce the behavior:

  1. Install Sohpisticated Backpacks, BetterCombat, and SimplySwords only.
  2. Start new world
  3. Equip to hotbar a Halberd, a basic Backpack, an Advanced Refill upgrade, and two full stacks of Torches.
  4. Place one of the torch stacks into offhand
  5. Open backpack and inside install the Advanced Refill upgrade.
  6. Open up Advanced Refill menu on the right hand side
  7. Click the first slot in that menu with a torch.
  8. Use Scrollwheel on the torch to set the torch to "Refill Off hand" mode
  9. Place the remaining stack of torches in the backpack.
  10. Use an empty hand to place torches on ground using the offhand. - Notice the offhand correctly refilling from backpack.
  11. Swap to Halberd.
  12. Swap off Halberd.
  13. Check backpack contents - the stack of torches inside will have been deleted

Expected behavior
Swapping to a two handed weapon should not delete items.

Screenshots or video recordings
Full video of reproduction steps

Additional context
I will be making the same bug report on Sophisticated Backpacks just in case this is an issue on their end rather than BetterCombat:
P3pp3rF1y/SophisticatedBackpacks#1438

commented

P3pp3rF1y just fixed this on their end in Sophisticated Backpacks with the following commit:
P3pp3rF1y/SophisticatedBackpacks@ba2912c

Closing this now.