Better Foliage

Better Foliage

35M Downloads

Round logs don't render in 1.12

fuzzybat23 opened this issue ยท 11 comments

commented

Round logs don't render and falling leaves don't fall in 1.12. Only get errors that it can't render block minecraft:log at possition x,y.z

commented

Falling leaves do work, my bad. But still, round logs don't work. I deleted my entire config folder and restarted minecraft to check.

commented

Can you post your betterfoliage.log file on Gist?

commented

Ugh, that was ugly. I'm just going to post the log file itself xD
betterfoliage.log.txt

commented

Looks like I'm having a similar issue and it seems to be caused by Good2know's Default 3D High resource pack (link: http://preview.tinyurl.com/ya7b5ejt) maybe it has to do with custom block models? I mean it does sound reasonable even though this resource pack doesn't alter the wood log block model.
I'll leave the log as txt file here just in case it comes in handy. (sorry I don't know how to use Glist either)
betterfoliage.txt

commented

In the config file, you can find it under the section blocks, with the key S:logModels.
Or in the in-game config menu, under Block Types and Wood Log Models.

But you shouldn't add these if you're not using Default3D. Lithos Core looks fine in this regard. It must be something else then.

commented

Yeah, Lithos Core use to be fine until betterfoliage was updated to 1.12... I just turned off my lithos resouce pack and went back to default and it works fine, logs are round and everything. There are 4 variations of every wooden log json file in the model directory of the resource pack, to use the game's built in system of choosing different textures, I assume. Perhaps this is something that betterfoliage could be updated to make use of? Either way, I had to delete all of the references to the wood logs in both the models and blockstates directories of the resource pack, forcing it to use only the base named texture and not the variants. It works now that I've done that.

commented

Yes, Default3D is definitely an issue (it does alter the log models, but it's not very visible). This might not be the reason why @fuzzybat23 is having his problems though.

That resourcepack is unfortunately very badly written. Not the models itself, but the fact that it doesn't follow the DRY principle. It's a giant collection of copy-pasted stuff. You can get it working, but it's ugly. You have to add the below lines to your wood log models list. I recommend to edit the config file directly, to avoid repetitive strain injury.

block/oak_log,top,bottom,side
block/oak_log_alt1,top,bottom,side
block/oak_log_alt2,top,bottom,side
block/oak_log_alt3,top,bottom,side
block/oak_log_alt4,top,bottom,side
block/oak_log_alt5,top,bottom,side
block/oak_log_side_alt1,top,bottom,side
block/oak_log_side_alt2,top,bottom,side
block/oak_log_side_alt3,top,bottom,side
block/oak_log_side_alt4,top,bottom,side
block/oak_log_side_alt5,top,bottom,side
block/spruce_log,top,bottom,side
block/spruce_log_alt1,top,bottom,side
block/spruce_log_alt2,top,bottom,side
block/spruce_log_alt3,top,bottom,side
block/spruce_log_alt4,top,bottom,side
block/spruce_log_alt5,top,bottom,side
block/spruce_log_side_alt1,top,bottom,side
block/spruce_log_side_alt2,top,bottom,side
block/spruce_log_side_alt3,top,bottom,side
block/spruce_log_side_alt4,top,bottom,side
block/spruce_log_side_alt5,top,bottom,side
block/jungle_log,top,bottom,side
block/jungle_log_alt1,top,bottom,side
block/jungle_log_alt2,top,bottom,side
block/jungle_log_alt3,top,bottom,side
block/jungle_log_alt4,top,bottom,side
block/jungle_log_alt5,top,bottom,side
block/jungle_log_side_alt1,top,bottom,side
block/jungle_log_side_alt2,top,bottom,side
block/jungle_log_side_alt3,top,bottom,side
block/jungle_log_side_alt4,top,bottom,side
block/jungle_log_side_alt5,top,bottom,side
block/dark_oak_log,top,bottom,side
block/dark_oak_log_alt1,top,bottom,side
block/dark_oak_log_alt2,top,bottom,side
block/dark_oak_log_alt3,top,bottom,side
block/dark_oak_log_alt4,top,bottom,side
block/dark_oak_log_alt5,top,bottom,side
block/dark_oak_log_side_alt1,top,bottom,side
block/dark_oak_log_side_alt2,top,bottom,side
block/dark_oak_log_side_alt3,top,bottom,side
block/dark_oak_log_side_alt4,top,bottom,side
block/dark_oak_log_side_alt5,top,bottom,side
block/birch_log,top,bottom,side
block/birch_log_alt1,top,bottom,side
block/birch_log_alt2,top,bottom,side
block/birch_log_alt3,top,bottom,side
block/birch_log_alt4,top,bottom,side
block/birch_log_alt5,top,bottom,side
block/birch_log_side_alt1,top,bottom,side
block/birch_log_side_alt2,top,bottom,side
block/birch_log_side_alt3,top,bottom,side
block/birch_log_side_alt4,top,bottom,side
block/birch_log_side_alt5,top,bottom,side
block/acacia_log,top,bottom,side
block/acacia_log_alt1,top,bottom,side
block/acacia_log_alt2,top,bottom,side
block/acacia_log_alt3,top,bottom,side
block/acacia_log_alt4,top,bottom,side
block/acacia_log_alt5,top,bottom,side
block/acacia_log_side_alt1,top,bottom,side
block/acacia_log_side_alt2,top,bottom,side
block/acacia_log_side_alt3,top,bottom,side
block/acacia_log_side_alt4,top,bottom,side
block/acacia_log_side_alt5,top,bottom,side

See what I mean? Those models should extend a common ancestor, so you could catch them all with a single line. I'll probably implement some kind of wildcard system in my model matching to make this easier with packs that are not so well-behaved.

Additionally, to get connected grass (mostly) working, add the following to the grass models list.

block/generic_grass,grass

commented

Where exactly is this wood log model list, or at least what is the actual name of the file? I'm using Lithos Core, which has always worked with BetterFoliage in the past..

commented

Yeah, you're right. The model variants are the reason. If it was working pre-1.12 then something changed that broke my support for it, and I didn't notice. I'll fix it.

commented

Geez that is a mess! thanks for the help! It seems too be working fine now! :^D

commented

Turns out I didn't have proper variant support at all, so a lot of the detail in the pack went to waste. That's fixed now in 2.1.8.
I've also added the LithosCore models in the default config, you'll need to revert it as usual to get it.