Better Foliage

Better Foliage

35M Downloads

Dynamic Trees leaves mismatch

ferreusveritas opened this issue ยท 6 comments

commented

I've been getting questions about why my leaves have the wrong "poofy things" texture on them when better foliage is installed. Can you help me understand what I(or we) need to do to make this compatible with better foliage? I thought your enhancements "keyed" off of the models but I may be mistaken.

commented

They should, and a quick look at your code shows you're not doing anything fancy (like generated models, special renderers, TEs). It's most likely on my side, could be buggy or incomplete multipart model support. I'll look into it.

commented

Thank you. Let me know if you need anything.

commented

I've started looking into this issue a bit myself, since I've started working on an addon for Dynamic Leaves, and I think I've figured out what the issue is (although I haven't actually looked at the code for Better Foliage, so I could be wrong, but this makes enough sense that I think I'm right).

It seems as though you were right about the problem being incomplete multipart model support on your end, octarine-noise, since the problem goes away if I replace Dynamic Tree's blockstates with new ones that use the Forge blockstate format. But the actual problem with multipart models seems to be that they hold all conditions in an array, and that array is interpreted by Better Foliage to be representing a random selection of models. That would explain why the texture of the extra leafy bits is determined by the position of the leaf block and not it's blockstate data, as well as why the fluffy extra bits on acacia and dark oak dynamic leaves are never black and purple.

Not sure how much that actually helps, I just found it interesting.

commented

The workaround created by the-realest-stu has been implemented and this is no longer technically an issue. Although the multipart issue in Better Foliage that is being worked around is still present. I'll leave it up to you as to whether or not you wish to close this issue. Thanks!

commented

Acacias and Dark Oaks are the effected leaves.

commented

The problem Misunderstood-Wookie is having may be unrelated to this issue and may require more testing to know for sure. They are getting solid cube leaves blocks seemingly at random or maybe where new leaves are created.