Better Foliage

Better Foliage

Mods
35M Downloads

ConnectedTexturesMod Incompatibility With Block Models

ChloeDawn opened this issue ยท 1 comments

commented

BetterFoliage version: MC1.12-2.2.0
CTM version: MC1.12.2-0.3.3.22

When I append metadata to my leaves block model, "extra leaves" no longer applies.

Standard model:

{
  "parent": "minecraft:block/oak_leaves"
}

Standard model screenshot

Model with CTM data:

{
  "parent": "minecraft:block/oak_leaves",
  "ctm_version": 1,
  "ctm_overrides": {
    "0": {
      "type": "normal",
      "extra": {
        "light": 15
      }
    }
  }
}

Ctm model screenshot

commented

The problem code would seem to be here:

BetterFoliage/src/main/kotlin/mods/octarinecore/client/resource/Utils.kt

Lines 104 to 118 in 36a3a38

@Suppress("UNCHECKED_CAST")
val IModel.modelBlockAndLoc: List<Pair<ModelBlock, ResourceLocation>> get() {
if (Refs.VanillaModelWrapper.isInstance(this))
return listOf(Pair(Refs.model_VMW.get(this) as ModelBlock, Refs.location_VMW.get(this) as ResourceLocation))
else if (Refs.WeightedRandomModel.isInstance(this)) Refs.models_WRM.get(this)?.let {
return (it as List<IModel>).flatMap(IModel::modelBlockAndLoc)
}
else if (Refs.MultiModel.isInstance(this)) Refs.base_MM.get(this)?.let {
return (it as IModel).modelBlockAndLoc
}
else if (Refs.MultipartModel.isInstance(this)) Refs.partModels_MPM.get(this)?.let {
return (it as Map<Any, IModel>).flatMap { it.value.modelBlockAndLoc }
}
return listOf()
}

Wherein you don't account for anyone wrapping Mojang/Forge model implementations? Unless I missed something.