Random Music Disk Bug
SMHerobrine opened this issue ยท 3 comments
Describe the bug
If you take a music disk out of a jukebox then the disk keeps playing
(Idk how your mod did it but VanillaFix said that Dynamic Trees and Better Foliage made this issue)
I have contacted dynamic Trees about this and they confirmed that's its not their issue, but here is their response:
The function in question is
@Override
public void playEvent(EntityPlayer player, int type, BlockPos blockPosIn, int data) {
Minecraft.getMinecraft().renderGlobal.playEvent(player, type, blockPosIn, data);
}
Which is simply a pass-thru for the IWorldEventListener interface in Dynamic Trees. That's the reason why it shows up in the crash log. But it's not Dynamic Trees that's causing the problem. It's also likely not Better Foliage for exactly the same reason.
However I don't understand the Kotlin code that octarine-noise uses to know for sure. I can say that this line: Caused by: java.lang.IllegalArgumentException: Parameter specified as non-null is null: method mods.betterfoliage.client.chunk.ChunkOverlayManager.func_184377_a, parameter soundIn
does appear to throw an error in Better Foliage saying that there's a null where there shouldn't be one. Might be worth putting in an issue over at Better Foliage to find out.
This info should help you
Crash Log: https://justpaste.it/5cgu5
Forge version- 1.12.2 - 14.23.5.2854
To Reproduce
Steps to reproduce the behavior:
1. Download my modpack: https://www.curseforge.com/minecraft/modpacks/the-sm-modpack
2. Make a new world (better if in creative)
3. Take a jukebox and a random music disk (+even modded disks have this issue)
4. But the disk in the jukebox and take it out, the music doesn't stop
Here's a little demonstration...
