Better Foliage

Better Foliage

35M Downloads

Freeze on the "Loading World" (With WorldEditWrapper)

LaughingLeader opened this issue ยท 8 comments

commented

I've opened this issue in WorldEditterWrapper's github as well, as I'm not entirely sure which mod is responsible for the error, as Minecraft doesn't crash with this bug - it simply freezes forever.

You can view that here: Mumfrey/WorldEditWrapper#3

Summary:

BetterFoliage, coupled with WorldEditWrapper & WorldEditCUI, freezes Minecraft upon loading a world.

Steps to produce the bug:

Install the WorldEditWrapper and WorldEditCUI mods, along with BetterFoliage, and run the game. Load (or create) a world and Minecraft should freeze, and will hang in this state perpetually.

Console Log:

https://gist.github.com/LaughingLeader/5db668236a9ccc750314

Mods:

WorldEdit/rhino-1_7r4.jar
WorldEdit/WorldEdit-5.6.2.jar
BetterFoliage-1.7.10-0.9.5b.jar
mod_worldeditwrapper_1.2.0_we5.6.2_mc1.7.10.litemod
mod_worldeditcui_1.7.10_00_mc1.7.10.litemod

BetterFoliage
LiteLoader
http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/1290155-liteloader-for-minecraft-1-7-10
WorldEditWrapper
http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/1294341-worldeditwrapper-use-worldedit-in-single-player
WorldEditCUI
http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/1292886-worldeditcui

Launcher

MultiMC
http://multimc.org/

commented

Does this even need WEW to be present to happen? I'm getting the feeling from the last few lines of your log (namely the integrated server loading 5-6 dimensions at once) that it's some race condition I overlooked, and nothing to do with WEW.

commented

Yes. If I disable WEW/WECUI, I can load the world just fine.

You can see here that it gets past where it previously froze:

[08:08:49] [Server thread/INFO]: Starting integrated minecraft server version 1.7.10
[08:08:49] [Server thread/INFO]: Generating keypair
[08:08:49] [Server thread/INFO] [FML]: Injecting existing block and item data into this server instance
[08:08:49] [Server thread/INFO] [FML]: Applying holder lookups
[08:08:49] [Server thread/INFO] [FML]: Holder lookups applied
[08:08:49] [Server thread/WARN]: Unable to find spawn biome
[08:08:49] [Server thread/INFO] [FML]: Loading dimension 0 (Test) (net.minecraft.server.integrated.IntegratedServer@18711ad)
[08:08:49] [Server thread/INFO] [FML]: Loading dimension 1 (Test) (net.minecraft.server.integrated.IntegratedServer@18711ad)
[08:08:49] [Server thread/INFO] [FML]: Loading dimension -1 (Test) (net.minecraft.server.integrated.IntegratedServer@18711ad)
[08:08:49] [Server thread/INFO]: Preparing start region for level 0
[08:08:51] [Server thread/INFO]: Preparing spawn area: 8%
[08:08:52] [Server thread/INFO]: Preparing spawn area: 19%
[08:08:53] [Server thread/INFO]: Preparing spawn area: 35%
[08:08:54] [Server thread/INFO]: Preparing spawn area: 52%
[08:08:55] [Server thread/INFO]: Preparing spawn area: 69%
[08:08:56] [Server thread/INFO]: Preparing spawn area: 88%
[08:08:56] [Server thread/INFO]: Changing view distance to 4, from 10
//Froze here
[08:08:57] [Netty Client IO #0/INFO] [FML]: Server protocol version 1
[08:08:57] [Netty IO #1/INFO] [FML]: Client protocol version 1
[08:08:57] [Netty IO #1/INFO] [FML]: Client attempting to join with 4 mods : [email protected],[email protected],[email protected],[email protected]
[08:08:57] [Netty IO #1/INFO] [FML]: Attempting connection with missing mods [] at CLIENT
[08:08:57] [Netty Client IO #0/INFO] [FML]: Attempting connection with missing mods [] at SERVER
[08:08:57] [Server thread/INFO] [FML]: [Server thread] Server side modded connection established
[08:08:57] [Server thread/INFO]: <PROFILE NAME>[local:E:3c98e9d6] logged in with entity id 155 at (-2.5, 66.0, -8.5)
[08:08:57] [Server thread/INFO]: <PROFILE NAME> joined the game
[08:08:57] [Client thread/INFO] [FML]: [Client thread] Client side modded connection established
[08:08:59] [Client thread/INFO]: Warning: Clientside chunk ticking took 264 ms
[08:09:00] [Server thread/INFO]: Saving and pausing game...
[08:09:00] [Server thread/INFO]: Saving chunks for level 'Test'/Overworld
[08:09:02] [Server thread/INFO]: Saving chunks for level 'Test'/Nether
[08:09:02] [Server thread/INFO]: Saving chunks for level 'Test'/The End
commented

This is a deadlock issue caused by a JDK bug.
In-depth explanation by @kenzierocks at Mumfrey/WorldEditWrapper#3

commented

Can you confirm it works with 0.9.7b?

commented

Sure.

Ran my instance that has just WEW/WECUI and BF... Everything appears to be working. I can load just fine.

Next, I ran it on my instance with all my mods - I could load the world again. However, this is after I disabled CustomLanPort - a mod I added recently for LAN. Not sure why, but it appears that BF, WEW, and CustomLanPort together causes the same freeze.

Ran further testing by loading up just BF and CustomLanPort: No problems there. CustomLanPort and WEW: Same thing. No issues.

All three together and it freezes.

Log:

https://gist.github.com/LaughingLeader/a3cce282220220ec451c

Mods:

WorldEdit/rhino-1_7r4.jar
WorldEdit/WorldEdit-5.6.2.jar
BetterFoliage-0.9.7b.jar
CustomLanPort-1.7.10-0.0.1.jar
mod_worldeditcui_1.7.10_00_mc1.7.10.litemod
mod_worldeditwrapper_1.2.0_we5.6.2_mc1.7.10.litemod

CustomLanPort:

http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/1294206-customlanport-mod

commented

My idea didn't work out so well, the locks are placed differently than I thought. It seems I really can't get away with using annotations, so I have to rework the class transformer :(

commented

Also, this could (if you wanted) be re-added when MC officially goes to Java 8. That might not happen for years though.