Better Hurt Timer

Better Hurt Timer

691k Downloads

Crash with first person model (they made a forge version)

Spoofygamer opened this issue ยท 5 comments

commented

I told the first person dev, and they managed to fix the issue in you mod with one line change.

crash-2021-01-19_16.47.37-client.txt

commented

The first person dev here, it seems like a concurrent modification/race condition is happening inside the Object2ObjectArrayMap used in BHTAPI. The mods themselves are compatible(tried firstpersonmod + betterhurttimer + optifine), but somehow the setup in the crash report causes this issue.

commented

I told the first person dev, and they managed to fix the issue in you mod with one line change.

crash-2021-01-19_16.47.37-client.txt

What was the change? :0

commented

I think I know what it was, it could have been a mod triggering a config reload event on a thread during the initialization of the configs. It's literally using a CompletableFuture.

commented

I can just mark it as synchronized...

commented

Also idk why I used Object2ObjectArrayMap, I should've known the implementation is horrible for lookup, changing it for a HashMap.