
[Suggestion] Ability to further modify how much stamina is depleted
zinx10 opened this issue ยท 3 comments
So, one of the things I noticed missing in the config file (or even attributes) are parameters to affect how much the attack speed or item rank counts for calculating stamina drain.
Ignoring the fact that not every mod developer accurately depicts an item rank (like MC Dungeons Weapons), sometimes it feels like the item rank (in my case) feels too impactful for stamina usage.
In theory, if it takes the same amount of time to swing a wooden sword and a netherite sword, that they might be of a similar weight? Which means it should take about the same amount of effort or stamina in this case. Yet the netherite sword takes a considerably larger amount of stamina compared to a wooden sword.
That's why, instead of only benefiting me and removing (or minimizing) the item rank's impact, we should be able to set percentiles (like the percentile for two-handed weapons) for how much the item rank and/or attack speed affect stamina drain. Of course, this would all be in the config file, but it'd obviously be nice to have these as attributes as well.
Now, hypothetically, this could also mean someone could set both item rank stamina drain and attack speed stamina drain both to 0.0 which would effectively make the mod not count.
So, I originally did make the mod work this way. I accounted for both swing speed and weapon tier, but the issue that arose there is that sometimes swing speed can sometimes make certain weapons more viable than others (like daggers since they barely drained any stamina. Something I had to fix by creating a lower bound for them), and the other issue is that not all mods use weapon tiers/ranks to define their weapons.
What I'm going to do to combat this issue is make it so that the mod datapack compatible in the next release. That way users can set the stamina drain to be whatever value for whatever weapon they want. Obviously, I'll still use my base system so most weapons are compatible right out of the box, but this way any user can fine tune the values to be exactly what they want for any weapon.
I've already done this with my Epic Paragliders mod and it worked pretty well, and I feel like it's a great middle ground.
That's fair. The only potential issue/annoyance I can see is mass-changing stamina usage by tier or attack speed.
But your middle ground method definitely works well enough.
Finally got around to adding support for this. Was a much bigger undertaking that I originally imagined lol. There should be full datapack support in V0.5.0 when it's released. Also, see here for my new wiki on how to use the datapacks