[3.5.267] NPE due BQ packet length changing
kreezxil opened this issue · 7 comments
A play in my World of Dragons modpack reported the following while on my server.
client log: https://paste.ee/p/XBRlz#s=0&l=2779
notes
NPE when moving from the end via a portal as spawn due BQ packet length changing
Interesting... didn't think this error would ever be thrown under normal circumstances. I'm going to give sponge the benefit of the doubt in this scenario and say it's not at fault for this crash. May also need to add more metadata to these packet errors, can't tell what kind of packets they were. Thanks for the report anyway, will take a look at this and see if I can include a fix next update.
Still haven't been able to recreate this but I am in the process of fixing another bug that might be related to this so we'll see how that goes when I release a fix for that.
As for the Sponge thing, seems LagGoggles was making ASM edits under the package name "spongepowered" which is somewhat confusing.
Also having this issue on our StoneBlock/Continuum server, multiple people getting fatal errors disconnects etc
I've been thinking of how to go about solving this but most solutions would break backwards compatibility or require many other things to be rewritten which can't be done any time soon. For now I'll catch and ignore the error, clean up the network buffer, and hopefully BQ can continue syncing afterwards without too much issue.
Try build 275 and see how that works for you.