Simultaneous Cooldowns going Negative
jelaw21 opened this issue · 19 comments
My cooldowns worked, until I ran a default load. Then any current cooldown timers, all went negative.
Nope it wasn't default load. If you have multiple quests on cooldowns, they won't reset until they are ALL off of cooldowns. I had 4 quests going negative and one positive. When the positive one hit zero, ALL of the quest reset to completed.
Could be dimension time differences. There's a known display bug there that occurs when you're in a non-overworld dimension. I plan to change how that math works in later builds to fix that.
I'm in the overworld. If it was a display bug, wouldn't it still say completed/unclaimed but the time would just be negative? Mine show completed/claimed until the positive one reset.
Then the only other thing I could think of would be edit mode. Resets are disabled while that's on.
So the top two were the 10 and 11 min quests, both now showing negative cause I still had a 30min cooldown going. You can see that they are still showing as completed/claimed.
This one shows the treant quest completed, and the other now completed to. At the same time.
I can second this, cooldowns going negative have never been in edit world in this world (i am always in edit mode in a seperate test world tho)
Almost allways in the overworld, yet if i remember correctly i have claimed the rewards with the claim all button don't know if that makes anything different
Oh... OHHHH. I think I figured it out. I did a dumb and sorted the scheduled resets backwards by mistake. That's why it seemingly 'works' all at once when the last reset passes 0s.
Unfortunately due to WIP code I can't put out a fix for 1.12.2 just yet. Will be included with the network change beta builds when those are ready.
On the surface that may seem easy but it wouldn't scale well with several hundred players all needing timers for each repeatable quest.
BQ doesn't actually even 'tick' those. It's just a timestamp of when the quest was last completed with some math to figure out how long till it reaches the reset duration.
It may seem overkill, but BQ needs to account for hundreds of players running thousands of quests on a server with hundreds of other mods.
Was the last update supposed to fix this, or am I still waiting for another BETA build update?
Yesterday all the negative cooldowns fixed itself, not sure if this was bc another cooldown was finished or not. They all had different cooldown times even in negative but all got off cooldown at the same time. I did not update anything of mods
dierke9, becuase of the broken sort order it does appear to 'fix' irself when the last timer passes 0s but in reality it'll still break the next time you have several in waiting again.