Better Respawn

Better Respawn

Mods
191k Downloads

Crash loading/unloading world

wendall911 opened this issue ยท 0 comments

commented

Please read the FAQ before submitting a bug report!

Bug description
If in a modpack (not sure the conflict) and generating a new world, if anything triggers a save data before loadSaveData is called, a crash occurs, as the AbilitiesMixin does not check if the dimension is set in: https://github.com/henkelmax/better-respawn/blob/master/common/src/main/java/de/maxhenkel/betterrespawn/mixin/AbilitiesMixin.java#L32

There is a conflict for example with Oh The Biomes You'll Go:
https://github.com/AOCAWOL/BYG/blob/1.19.X/Common/src/main/java/potionstudios/byg/mixin/common/MixinPlayerList.java

Steps to reproduce the issue

  1. Add mod to 1.19.2 w/Forge to large modpack
  2. Generate new world
  3. Try to exit world
  4. Crash

Expected behavior
Check if respawnDimension is set.

Log files

[09:07:12] [Server thread/ERROR] [minecraft/MinecraftServer]: Exception stopping the server
net.minecraft.ReportedException: Saving entity NBT
	at net.minecraft.world.entity.Entity.m_20240_(Entity.java:1546) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.client.server.IntegratedPlayerList.m_6765_(IntegratedPlayerList.java:25) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:classloading}
	at net.minecraft.server.players.PlayerList.m_11302_(PlayerList.java:629) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:mixin,re:classloading,pl:mixin:APP:byg.mixins.json:common.MixinPlayerList,pl:mixin:APP:assets/better_respawn/better_respawn.mixins.json:PlayerListMixin,pl:mixin:A}
	at net.minecraft.server.MinecraftServer.m_7041_(MinecraftServer.java:548) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
	at net.minecraft.client.server.IntegratedServer.m_7041_(IntegratedServer.java:173) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:682) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
	at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:244) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
	at java.lang.Thread.run(Thread.java:833) [?:?] {re:mixin}
Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.resources.ResourceKey.m_135782_()" because "this.respawnDimension" is null
	at net.minecraft.world.entity.player.Abilities.handler$zck000$addSaveData(Abilities.java:532) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:mixin,re:classloading,pl:mixin:APP:assets/better_respawn/better_respawn.mixins.json:AbilitiesMixin,pl:mixin:A}
	at net.minecraft.world.entity.player.Abilities.m_35945_(Abilities.java:26) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:mixin,re:classloading,pl:mixin:APP:assets/better_respawn/better_respawn.mixins.json:AbilitiesMixin,pl:mixin:A}
	at net.minecraft.world.entity.player.Player.m_7380_(Player.java:800) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:byg.mixins.json:common.entity.MixinPlayer,pl:mixin:A}
	at net.minecraft.server.level.ServerPlayer.m_7380_(ServerPlayer.java:322) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:byg.mixins.json:common.entity.MixinServerPlayer,pl:mixin:APP:assets/better_respawn/better_respawn.mixins.json:ServerPlayerMixin,pl:mixin:A}
	at net.minecraft.world.entity.Entity.m_20240_(Entity.java:1525) ~[client-1.19.2-20220805.130853-srg.jar%23129!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}

Versions

  • 1.19.2
  • 43.1.25
  • 2.0.0

Other mods
Oh_The_Biomes_You'll_Go-forge-1.19.2-2.0.0.11.jar - 2.0.0.11
TerraBlender-forge-1.19.2-2.0.1.127.jar - 2.0.1.127