Better Trims

Better Trims

4M Downloads

changing trim_durability value in config doesn't seem to work, possibly others as well

notandvm opened this issue ยท 3 comments

commented

tested with the only mods installed being fabric api and bettertrims

due to some other mods i'm running in a pack i found that trim durability made them a bit overpowered however when i went to edit the config down to the vanilla value of 1 durability the in-game durability did not change, and still allowed for two uses per trim. the same applied if i then increased durability to something like 3 or 20.

same issue seems to apply to the other options as well, such as redstone's speed bonus

commented

Hmm, that definitely shouldn't be happening. Can you send your latest.log as this sounds like the mod is failing to read the config and just reverting to the default.

commented

[17:27:26] [main/INFO]: Loading Minecraft 1.20.1 with Fabric Loader 0.14.21
[17:27:26] [main/INFO]: Loading 55 mods:
- bettertrims 1.0.2
-- com_github_llamalad7_mixinextras 0.2.0-beta.8
- fabric-api 0.84.0+1.20.1
|-- fabric-api-base 0.4.29+b04edc7a77
|-- fabric-api-lookup-api-v1 1.6.34+4d8536c977
|-- fabric-biome-api-v1 13.0.10+b3afc78b77
|-- fabric-block-api-v1 1.0.9+e022e5d177
|-- fabric-blockrenderlayer-v1 1.1.39+b3afc78b77
|-- fabric-client-tags-api-v1 1.0.20+b3afc78b77
|-- fabric-command-api-v1 1.2.32+f71b366f77
|-- fabric-command-api-v2 2.2.11+b3afc78b77
|-- fabric-commands-v0 0.2.49+df3654b377
|-- fabric-containers-v0 0.1.61+df3654b377
|-- fabric-content-registries-v0 4.0.7+b3afc78b77
|-- fabric-convention-tags-v1 1.5.3+b3afc78b77
|-- fabric-crash-report-info-v1 0.2.18+aeb40ebe77
|-- fabric-data-generation-api-v1 12.1.11+b3afc78b77
|-- fabric-dimensions-v1 2.1.51+b3afc78b77
|-- fabric-entity-events-v1 1.5.21+b3afc78b77
|-- fabric-events-interaction-v0 0.6.0+b3afc78b77
|-- fabric-events-lifecycle-v0 0.2.61+df3654b377
|-- fabric-game-rule-api-v1 1.0.38+b04edc7a77
|-- fabric-item-api-v1 2.1.26+b3afc78b77
|-- fabric-item-group-api-v1 4.0.7+b3afc78b77
|-- fabric-key-binding-api-v1 1.0.36+fb8d95da77
|-- fabric-keybindings-v0 0.2.34+df3654b377
|-- fabric-lifecycle-events-v1 2.2.20+b3afc78b77
|-- fabric-loot-api-v2 1.1.37+b3afc78b77
|-- fabric-loot-tables-v1 1.1.41+9e7660c677
|-- fabric-message-api-v1 5.1.6+b3afc78b77
|-- fabric-mining-level-api-v1 2.1.47+b3afc78b77
|-- fabric-models-v0 0.3.35+b3afc78b77
|-- fabric-networking-api-v1 1.3.8+b3afc78b77
|-- fabric-networking-v0 0.3.48+df3654b377
|-- fabric-object-builder-api-v1 11.0.6+b3afc78b77
|-- fabric-particles-v1 1.0.28+b3afc78b77
|-- fabric-recipe-api-v1 1.0.18+b3afc78b77
|-- fabric-registry-sync-v0 2.2.6+b3afc78b77
|-- fabric-renderer-api-v1 3.1.0+c154966e77
|-- fabric-renderer-indigo 1.4.0+c154966e77
|-- fabric-renderer-registries-v1 3.2.44+df3654b377
|-- fabric-rendering-data-attachment-v1 0.3.33+b3afc78b77
|-- fabric-rendering-fluids-v1 3.0.26+b3afc78b77
|-- fabric-rendering-v0 1.1.47+df3654b377
|-- fabric-rendering-v1 3.0.6+b3afc78b77
|-- fabric-resource-conditions-api-v1 2.3.5+ea08f9d877
|-- fabric-resource-loader-v0 0.11.7+f7923f6d77
|-- fabric-screen-api-v1 2.0.6+b3afc78b77
|-- fabric-screen-handler-api-v1 1.3.27+b3afc78b77
|-- fabric-sound-api-v1 1.0.12+b3afc78b77
|-- fabric-transfer-api-v1 3.2.2+b3afc78b77
-- fabric-transitive-access-wideners-v1 4.2.0+b3afc78b77
- fabricloader 0.14.21
- java 17
- minecraft 1.20.1
[17:27:26] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=file:/home/deck/.var/app/org.prismlauncher.PrismLauncher/data/PrismLauncher/libraries/net/fabricmc/sponge-mixin/0.12.5+mixin.0.8.5/sponge-mixin-0.12.5+mixin.0.8.5.jar Service=Knot/Fabric Env=CLIENT
[17:27:26] [main/INFO]: Compatibility level set to JAVA_17
[17:27:27] [main/WARN]: Reference map 'client-bettertrims-refmap.json' for bettertrims.client.mixins.json could not be read. If this is a development environment you can ignore this message
[17:27:27] [main/INFO]: PreLaunching Better Trims
[17:27:34] [Datafixer Bootstrap/INFO]: 188 Datafixer optimizations took 242 milliseconds
[17:27:37] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[17:27:37] [Render thread/INFO]: Setting user: notandvm
[17:27:37] [Render thread/INFO]: Initializing Better Trims
[17:27:37] [Render thread/INFO]: Loaded config
[17:27:37] [Render thread/INFO]: Initializing Better Trims Client
[17:27:38] [Render thread/INFO]: [Indigo] Registering Indigo renderer!
[17:27:38] [Render thread/INFO]: Backend library: LWJGL version 3.3.1 SNAPSHOT
[17:27:39] [Render thread/INFO]: Reloading ResourceManager: vanilla, fabric (bettertrims, fabric-api, fabric-api-base, fabric-api-lookup-api-v1, fabric-biome-api-v1, fabric-block-api-v1, fabric-blockrenderlayer-v1, fabric-client-tags-api-v1, fabric-command-api-v1, fabric-command-api-v2, fabric-commands-v0, fabric-containers-v0, fabric-content-registries-v0, fabric-convention-tags-v1, fabric-crash-report-info-v1, fabric-data-generation-api-v1, fabric-dimensions-v1, fabric-entity-events-v1, fabric-events-interaction-v0, fabric-events-lifecycle-v0, fabric-game-rule-api-v1, fabric-item-api-v1, fabric-item-group-api-v1, fabric-key-binding-api-v1, fabric-keybindings-v0, fabric-lifecycle-events-v1, fabric-loot-api-v2, fabric-loot-tables-v1, fabric-message-api-v1, fabric-mining-level-api-v1, fabric-models-v0, fabric-networking-api-v1, fabric-networking-v0, fabric-object-builder-api-v1, fabric-particles-v1, fabric-recipe-api-v1, fabric-registry-sync-v0, fabric-renderer-api-v1, fabric-renderer-indigo, fabric-renderer-registries-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-rendering-v0, fabric-rendering-v1, fabric-resource-conditions-api-v1, fabric-resource-loader-v0, fabric-screen-api-v1, fabric-screen-handler-api-v1, fabric-sound-api-v1, fabric-transfer-api-v1, fabric-transitive-access-wideners-v1, fabricloader)
[17:27:39] [Worker-Main-4/INFO]: Found unifont_all_no_pua-15.0.06.hex, loading
[17:27:42] [Render thread/WARN]: Missing sound for event: minecraft:item.goat_horn.play
[17:27:42] [Render thread/WARN]: Missing sound for event: minecraft:entity.goat.screaming.horn_break
[17:27:42] [Render thread/INFO]: OpenAL initialized on device ACP/ACP3X/ACP6x Audio Coprocessor Headphones
[17:27:42] [Render thread/INFO]: Sound engine started
[17:27:42] [Render thread/INFO]: Created: 1024x512x4 minecraft:textures/atlas/blocks.png-atlas
[17:27:42] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas
[17:27:42] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[17:27:42] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[17:27:42] [Render thread/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/armor_trims.png-atlas
[17:27:42] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas
[17:27:42] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[17:27:42] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[17:27:42] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[17:27:43] [Render thread/WARN]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program.
[17:27:43] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas
[17:27:43] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas
[17:27:43] [Render thread/INFO]: Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[17:27:47] [Render thread/INFO]: Stopping!

commented

Yeah I found the issue, I was reading the config after the changes were applied to the various trims, thus, it was always using the default. This is fixed in 1.0.3