Tiles load before blocks causing null blockstate crash

Question

Tiles load before blocks causing null blockstate crash

katubug opened this issue 5 years ago · 4 comments

katubug commented 5 years ago

Describe what you were doing before the crash
So some friends and I were messing around with a command block that would /kill you if you pressed a button (we were bored I guess? I have no good excuse). And about every second or third time we died from it, we got disconnected from the server, with the attached crash log.

My assumption is that this is somehow related to the fact that players drop their heads upon death (which I thiiiiink is from Quark? I've attached my modlist in case it's something else). There are still some textureless heads in JEI so perhaps they're somehow related? Unsure.

To Reproduce (Required unless unknown)
Steps to reproduce the behavior (if possible):

Type /kill @p
Die, drop head.
Crash occurs.

Crash Log (REQUIRED)
https://paste.dimdev.org/otopefomoh.mccrash

Versions:

Forge Version: forge-1.12.2-14.23.5.2838-universal
MC Version: 1.12.2
Mod Version: betteranimalsplus-1.12.2-6.0.1

Additional context
Here is my full modlist: mods.txt

itsmeow · Answer 1 · 2019-05-27T06:33:00.000Z

There's something missing here, players do not drop any BA+ heads. The affected head is a block located at x 451, y 76, z 1940. It should be a hirschgeist skull. I've identified the bug, it seems it was rendering while the block itself was not loaded, causing the blockstate to be null, and by extension crashing the game while rendering. Not sure what actually caused the issue, maybe someone respawned near it and saw it without the chunk being loaded? I have no idea. I will resolve this.

katubug · Answer 2 · 2019-05-27T06:48:36.000Z

Ah, that makes total sense actually. We have a Hirschgeist skull hanging in our spawn lodge and that's where we were respawning. Sorry for the red herring player heads, sometimes I think I know more than I do, lol. Thanks for your response and for providing such good support for the mod.

…

On Mon, May 27, 2019, 1:33 AM its_meow ***@***.***> wrote: There's something missing here, players do not drop any BA+ heads. The affected head is a block located at x 451, y 76, z 1940. It should be a hirschgeist skull. I've identified the bug, it seems it was rendering while the block itself was not loaded, causing the blockstate to be null, and by extension crashing the game while rendering. Not sure what actually caused the issue, maybe someone respawned near it and saw it without the chunk being loaded? I have no idea. I will resolve this.

itsmeow · Answer 3 · 2019-05-27T07:07:03.000Z

And just a btw, the broken heads in JEI are because I recently "flattened" the heads, each variant has their own item ID now. I had to put an item on the original IDs so that when the world loaded it would not say "Missing ID conflict for ___ item".

katubug · Answer 4 · 2019-05-27T22:36:45.000Z

Ah okay! I just hid them from JEI in my pack, so it's not at all a big deal. :)

Share to