BetterEnd

BetterEnd

Mods
27M Downloads

[Bug] Compat issue with Armored Elytra and Better End

mrmelon54 opened this issue · 2 comments

commented

What happened?

Copied from comment on CurseForge

Also, slight correction, it crashes when I put on the Armoured Elytra, not when I pick it up. And if I relaunch Minecraft and rejoin the world where I put the Armoured Elytra on it works fine, until I try to open the inventory and it crashes.

Minecraft 1.19.2 and 1.19.3 (I tried both)

armored-elytra-mc1.19-4.0.0+build.20.jar

betterend-2.1.4 [1.19.2] and betterend-3.1.2 [1.19.3]

Log:
1.19.3: https://mclo.gs/LBXMh6H
1.19.2: https://mclo.gs/I3PApPF

I'm the developer for Armored Elytra and am willing to work with you to fix the compat issue between our mods.

It looks like as both mods inject into ArmorFeatureRenderer::render it causes the be_storedEntity to not be set and thus crashes with the null exception.

BetterEnd/src/main/java/shadow/fabric/mixin/client/rendering/MixinArmorFeatureRenderer.java

Lines 70 to 86 in ee39902

@Inject(method = "render", at = @At("HEAD"))
private void be_storeEntity(
PoseStack matrixStack,
MultiBufferSource vertexConsumerProvider,
int i,
LivingEntity livingEntity,
float f,
float g,
float h,
float j,
float k,
float l,
CallbackInfo ci
) {
// We store the living entity wearing the armor before we render
this.be_storedEntity = livingEntity;
}

BetterEnd

3.1.2

BCLib

2.2.4

Fabric API

0.73.2

Fabric Loader

0.14.14

Minecraft

1.19.3

Relevant log output

No response

Other Mods

No response

commented

I am really sorry for the late response :( And thank you very much for the offer to help together. This is very much appreciated!

In the meantime (again sorry for the delay and the trouble this might have caused you), BetterEnd transitioned away from using that mixin. The 1.19.4 and 1.20 versions already use the new System, and 1.19.2 will get an update really soon. That should fix the combat issue, I guess.

commented

Ok cool, I'm still working on 1.20 updates so I guess I'll test it against this mod and hopefully it should work fine.

  • 👍1