BetterEnd

BetterEnd

27M Downloads

[Bug] Terminite Armor Considered a Weapon

NIGHT-PHAZED opened this issue ยท 2 comments

commented

What happened?

Decided to test the newest update of better end and while messing around with the stuff, found that the terminite armor instead of displaying armor stats, displays weapon stats. I can one shot a cow with the helmet. The armor doesn't actually give any protection when worn, purely visual. Not game breaking but its weird none the less. 1.21 + btw. Will see if its on my end, idk.

BetterEnd

21.05

BCLib

21.0.9

Fabric API

0.100.1

Fabric Loader

0.15.6

Minecraft

1.20.4

Relevant log output

No response

Other Mods

No response

commented

This is also true of Thallasium armor. Furthermore, Armored Elytra and Crystalite Elytra both give main-hand bonuses of +5 Knockback Resistance.

Finally:

  • Armored Elytra
  • Crystalite Elytra
  • Crystalite Chestplate

all have identical armor and armor toughness values (which wasn't true in 1.20.4)

I'm guessing the identical stats issue is because defense and toughness go unused in this method:

public static ItemAttributeModifiers.Builder startAttributeBuilder(
ArmorSlot slot,
ArmorTier tier,
int defense,
float toughness,
float knockbackResistance
) {

(slot and tier are unused as well, but it looks like they get used in a different method)

commented

Just a quick update here: I noticed that the armor items had identical stats to their tier's end hammer. Moving the end hammer registration to after the armor generation gave the armor items negative attack damage and a completely different attack speed. That is to say: something very funky is going on here.

... aand that was the hint I needed. My PR now includes a fix for this.