[Bug] Mixin error on Quilt
Sunconure11 opened this issue ยท 21 comments
What happened?
Mixin error. Happens on Quilt, causes other mods to have issues
https://gist.github.com/Sunconure11/58d82e41bddef982195cca3cc12ecdd7
BetterEnd
2.0.9
BCLib
2.0.16
Fabric API
No response
Fabric Loader
No response
Minecraft
1.19
Relevant log output
https://gist.github.com/Sunconure11/58d82e41bddef982195cca3cc12ecdd7Other Mods
https://gist.github.com/Sunconure11/58d82e41bddef982195cca3cc12ecdd7
Thanks for opening an Issue. From what I can see, this is caused by an interaction with another mod and is not a Quilt specific issue.
Multiple mods appear to inject to the same method in the ModelBakery. Since we are processed second, the error just mentions our mod. I can try to change our Mixin, but that may not resolve the conflict...
Still present.
Aaaand the crash that ended up leading me to deducing Better End as a cause of a potential error here came back.
Creeper Overhaul
Biome Makeover
Terrablender
Arcanus
Spoorn Pink
Spoorn Packs
Left Hanging
Reaping
MC Dungeons + Story suite
Requiem
Enhanced Block Entities
Better End?
These are the mods I went through, BTW, to find this mod as a possible error source.
Unfortunately those logs are inconclusive as to what is the root cause. The only way to solve this is by disabling one mod at a time and testing if the crashes are still there. I know it is tedious, but in situations like this it is the only way.
I would however start with performance/non essential Mods like NotEnoughCrashes, DashLoader and so on.
The mod at fault is...
If you wanna see the logs that led me to this, here it is.
If you can, see if you can go over Arcanus' code and see if they are doing something there.
https://gist.github.com/Sunconure11/58d82e41bddef982195cca3cc12ecdd7
Log of interest.
Are you using redirects?
This is the log from the old version.
From what I have seen so far, the remaining issues have nothing to do with BetterEnd or BCLib. That is why I closed the issue. I also think that the issue Title over at Arcanus and HangMan is misleading, as this has nothing to do with BetterEnd.
Since Redirects are dangerous (they prevent other Mods from changing that logic), we use them sparingly. Currently only in the Class for the NetherPortal where we use it to allow Blocks other than Obsidian as Portal-Frames and when the list EditorPresets get's initialised to ensure that the List is mutable.
Hard Errors with mixing (the ones that cause a crash) have a pretty clear log message that tells users that two redirects were attempted but failed. Other errors are soft-fails (where other mods try to modify the original behaviour but fail, since that behaviour is never called). Our redirects are carefully designed and deliberately chosen to prevent (or at least significantly lower the chance for) the later type of fail.
So again, as far as I can see, this is no longer related to BetterEnd.
I'll come back to this with new info once more mods update/properly mark themselves for 1.19.1. I cannot do more testing as a result.