Custom recipes added through datapacks do not display in EMI [1.19.2]
lxly9 opened this issue · 15 comments
What happened?
Ive been writing a datapack and after much trial, error and help I got it to work. Problem now is that when loading the datapack the recipes for the items do not appear in EMI. The recipes are all for the infusion ritual and basically only craft enchantments.
BetterEnd
2.1.0
BCLib
2.1.0
Fabric API
0.61.0
Fabric Loader
0.14.9
Minecraft
1.19.1
Relevant log output
No response
Other Mods
- additionaladditions 5.0.2
- adorn 3.6.1+1.19
- advanced_runtime_resource_pack 0.6.2 via enhancedblockentities
- advancednetherite 1.6.4-1.19.2
- adventurez 1.4.16
- ambientsounds 5.2.5
- amecsapi 1.3.6+mc22w17a via mousewheelie
- amethysttools v1.0_fabric+quilt_mc1.19.x
- another_furniture 1.2.1-1.19
- anvilrestoration-fabric 1.6
- appleskin 2.4.1+mc1.19
- aqupdgrizzly 1.19.2-1.3
- arcanus 1.30
- archeology 0.1.10
- architects_palette 2.1.1
- architectury 6.2.46
- armorchroma 1.2.2
- bclib 2.1.0
- beaconoverhaul 1.7.3+1.19.2
- bettercombat 1.3.1+1.19
- betterend 2.1.0
- bettermounthud 1.1.4
- biomemakeover 1.19.2-1.5.12
- blue_endless_jankson 1.2.1 via owo
- blur 2.6.0
- boatiview 0.0.4
- bookshelf 16.1.5
- bosses_of_mass_destruction 1.4.1-1.19
- caffeineconfig 1.0.0+1.17 via sodium-extra
- cardinal-components-base 5.0.1 via enchancement
- cardinal-components-block 5.0.1 via polymorph
- cardinal-components-chunk 5.0.1 via puzzleslib
- cardinal-components-entity 5.0.1 via enchancement
- cardinal-components-item 5.0.1 via polymorph
- cardinal-components-world 5.0.1 via enchancement
- cem 0.7.1
- charm 4.2.2
- charmofundying 6.0.0+1.19.2
- charmonium 4.1.0
- chat_heads 0.7.1
- chime 1.3.0
- cinderscapes 3.0.0
- cinderscapes-client 3.0.0 via cinderscapes
- cinderscapes-common 3.0.0 via cinderscapes
- cinderscapes-worldgen 3.0.0 via cinderscapes
- clear-skies 2.0.94
- clickthrough 1.19.1-fabric0.58.5-0.4
- cloth-basic-math 0.6.1 via cloth-config
- cloth-config 8.2.88 via shulkerboxtooltip
- clumps 9.0.0+11
- cmods 1.3.1+fabric-1.19 via purpeille
- coat 1.0.0-beta.18+mc22w17a via mousewheelie
- collective-fabric 4.64
- com_electronwill_night-config_core 3.6.5 via forgeconfigapiport
- com_electronwill_night-config_toml 3.6.5 via forgeconfigapiport
- com_eliotlash_mclib_mclib 18 via geckolib3
- com_eliotlash_molang_molang 18 via geckolib3
- com_github_llamalad7_mixinextras 0.0.12 via cull-less-leaves
- com_logisticscraft_occlusionculling 0.0.6-SNAPSHOT via entityculling
- com_moandjiezana_toml_toml4j 0.7.2 via charm
- completeconfig 2.0.0
- completeconfig-base 2.0.0 via completeconfig
- completeconfig-gui-cloth 2.0.0 via completeconfig
- completeconfig-gui-coat 2.0.0 via completeconfig
- conditional-mixin 0.3.0 via cull-less-leaves
- connectiblechains 2.1.3+1.19.2
- consistency_plus 0.5.1+1.19.2
- continuity 2.0.1+1.19
- controlling 10.0+6
- creativecore 2.8.5
- creaturesofthesnow 3.0.0+1.19.2
- creeperoverhaul 2.0.3
- crops_love_rain 1.3.0
- crowdin-translate 1.4+1.19 via clickthrough
- culinaire 2.5.0
- cull-less-leaves 1.0.5
- customsplashscreen 1.2.0
- dawn 3.5.0
- deepslatecutting 1.4.0
- disenchanter 0.1.7+1.19
- draggable-resource-packs 3.0.1+build.9
- dynamicfps 2.2.0
- earthtojavamobs 1.9.0
- eatinganimationid 1.9
- echoplus 0.1.2
- ecologics 2.1.10
- effective 1.2.2
- emi 0.4.0+1.19
- emitrades 1.0.2+mc1.19.2
- enchancement 1.19-4
- enchantmentcompat 1.0.1
- enchdesc 13.0.3
- enderscape 0.3.5-1.19.1
- enhanced_attack_indicator 1.0.4+1.19
- enhancedblockentities 0.7.1+1.19
- entity_texture_features 4.1.1
- entityculling 1.5.2-mc1.19
- extendedclouds 1.2.0
- extrasounds 2.3.1+1.19.2-1.19.1
- fabric-api 0.61.0+1.19.2
- fabric-api-base 0.4.11+e62f51a390 via beaconoverhaul
- fabric-api-lookup-api-v1 1.6.9+9ff28f4090 via fabric-api
- fabric-biome-api-v1 9.0.17+aeb40ebe90 via fabric-api
- fabric-blockrenderlayer-v1 1.1.20+aeb40ebe90 via fabric-api
- fabric-client-tags-api-v1 1.0.1+b35fea8390 via fabric-api
- fabric-command-api-v1 1.2.11+f71b366f90 via fabric-api
- fabric-command-api-v2 2.1.7+0c17ea9690 via fabric-api
- fabric-commands-v0 0.2.28+df3654b390 via fabric-api
- fabric-containers-v0 0.1.34+df3654b390 via fabric-api
- fabric-content-registries-v0 3.3.0+624e468e90 via fabric-api
- fabric-convention-tags-v1 1.1.1+7cd20a1490 via fabric-api
- fabric-crash-report-info-v1 0.2.5+aeb40ebe90 via fabric-api
- fabric-data-generation-api-v1 5.1.9+a680b9b490 via fabric-api
- fabric-dimensions-v1 2.1.31+0dd10df690 via fabric-api
- fabric-entity-events-v1 1.4.18+9ff28f4090 via fabric-api
- fabric-events-interaction-v0 0.4.28+aeb40ebe90 via fabric-api
- fabric-events-lifecycle-v0 0.2.28+df3654b390 via fabric-api
- fabric-game-rule-api-v1 1.0.21+aeb40ebe90 via fabric-api
- fabric-item-api-v1 1.5.7+35a03c4390 via fabric-api
- fabric-item-groups-v0 0.3.29+4e8ca3fd90 via fabric-api
- fabric-key-binding-api-v1 1.0.20+aeb40ebe90 via fabric-api
- fabric-keybindings-v0 0.2.18+df3654b390 via fabric-api
- fabric-language-kotlin 1.8.3+kotlin.1.7.10
- fabric-lifecycle-events-v1 2.1.2+aeb40ebe90 via fabric-api
- fabric-loot-api-v2 1.1.3+83a8659290 via fabric-api
- fabric-loot-tables-v1 1.1.6+9e7660c690 via fabric-api
- fabric-message-api-v1 5.0.3+176380a290 via fabric-api
- fabric-mining-level-api-v1 2.1.14+33fbc73890 via fabric-api
- fabric-models-v0 0.3.17+aeb40ebe90 via fabric-api
- fabric-networking-api-v1 1.2.4+5eb68ef290 via beaconoverhaul
- fabric-networking-v0 0.3.21+df3654b390 via fabric-api
- fabric-object-builder-api-v1 4.0.11+aeb40ebe90 via fabric-api
- fabric-particles-v1 1.0.10+aeb40ebe90 via fabric-api
- fabric-permissions-api-v0 0.1-SNAPSHOT via spark
- fabric-registry-sync-v0 0.9.25+726b652090 via beaconoverhaul
- fabric-renderer-api-v1 1.0.10+aeb40ebe90 via fabric-api
- fabric-renderer-indigo 0.6.12+aeb40ebe90 via fabric-api
- fabric-renderer-registries-v1 3.2.20+df3654b390 via fabric-api
- fabric-rendering-data-attachment-v1 0.3.14+aeb40ebe90 via fabric-api
- fabric-rendering-fluids-v1 3.0.7+aeb40ebe90 via fabric-api
- fabric-rendering-v0 1.1.22+df3654b390 via fabric-api
- fabric-rendering-v1 1.10.16+aeb40ebe90 via fabric-api
- fabric-resource-conditions-api-v1 2.0.11+e62f51a390 via fabric-api
- fabric-resource-loader-v0 0.6.1+aeb40ebe90 via beaconoverhaul
- fabric-screen-api-v1 1.0.26+f05effaf90 via fabric-api
- fabric-screen-handler-api-v1 1.3.0+1cc24b1b90 via fabric-api
- fabric-textures-v0 1.0.20+aeb40ebe90 via fabric-api
- fabric-transfer-api-v1 2.1.0+8f88597390 via fabric-api
- fabric-transitive-access-wideners-v1 1.3.0+42d99c3290 via fabric-api
- fabricloader 0.14.9
- fallingleaves 1.12.2+1.19.2
- fiber 0.23.0-2 via collective-fabric
- forgeconfigapiport 4.2.6
- forgetmechunk 1.0.4-1.18.X-1.19.X
- frame 0.26.1+1.19-fabric
- frame-api-base 0.2.1+906ebc04a9 via frame
- frame-blocks-v0 0.1.3+233e7428a9 via frame
- frame-config-v0 0.3.1+0fa45150a9 via frame
- frame-content-registries-v0 0.4.0+2876b511a9 via frame
- frame-enchantments-v0 0.1.0+4093105da9 via frame
- frame-game-rules-v0 0.2.4+e7ce56a6a9 via frame
- frame-items-v0 0.1.3+906ebc04a9 via frame
- frame-loot-tables-v0 0.1.4+4f7341eca9 via frame
- frame-registries-v0 0.1.1+0e0ec74ea9 via frame
- frame-rendering-v0 0.1.5+906ebc04a9 via frame
- frame-tabbed-item-groups-v0 0.2.4+0aca9b56a9 via frame
- frame-toymaker-v0 0.6.1+b13741c3a9 via frame
- frame-woods-v0 0.2.1+6a33fbada9 via frame
- friendsandfoes 1.5.10
- fwaystones 3.0.3+mc1.19.2
- gbfabrictools 1.3.4+1.19 via clickthrough
- geckolib3 3.1.0
- geodes 1.5.1
- globaldataandresourcepacks 1.14.2_fabric
- hellish-materials 0.15.2
- highlight 1.0.0
- highlighter 1.1.4
- iceberg 1.0.46
- illagerexp 1.0.0
- immersive_weathering 1.0.0-1.19
- impactfulweather 4.0.2
- impaled 1.1.4
- incendium 5.1.0
- indium 1.0.9+mc1.19.2
- ingredient-extension-api 3.0.3
- interactic 0.1.10+1.19
- iris 1.3.1
- itemmodelfix 1.0.3+1.19
- jankson 4.1.1+j1.2.1 via libgui
- java 17
- jsonem 0.1.2+1.19
- kirin 1.11.0 via voidfog
- lambdabettergrass 1.3.0+1.19
- lambdynlights 2.1.2+1.19
- lazydfu 0.1.3
- libgui 6.0.0-beta.5+1.19-pre1 via additionaladditions
- libninepatch 1.1.0 via libgui
- lithium 0.8.3
- lovely_snails 1.1.0+1.19
- maelstrom_library 1.3-1.19-pre1 via bosses_of_mass_destruction
- make_bubbles_pop 0.0.2-1.19
- mavm 1.1.0
- maybe-data 1.3.1-1.18.2 via deepslatecutting
- me_hypherionmc_simplerpc_simple-rpc-common 4.0.3 via simple-rpc
- midnightlib 0.5.2 via blur
- minecraft 1.19.2
- missingwilds 1.1.2
- mm 2.3 via illagerexp
- modify-drops-api 0.4.0.2 via hellish-materials
- modmenu 4.0.6
- moreculling 1.19.1-0.10.0
- moremcmeta 1.19-3.0.5
- morevillagers 4.0.2
- mousewheelie 1.10.2+mc1.19-pre1
- multipart_entities 1.2-1.19-pre1 via bosses_of_mass_destruction
- nbtcrafting 2.2.0+mc1.19
- nears 1.2.2
- no-resource-pack-warnings 1.0.0
- no-telemetry 1.4.0
- nochatreports 1.19.2-v1.12.0
- notenoughanimations 1.6.1
- onsoulfire 1.19-2
- optigui 1.1.2
- org_anarres_jcpp 1.4.14 via iris
- org_apache_commons_commons-text 1.9 via optigui
- org_apache_httpcomponents_httpmime 4.5.10 via entity_texture_features
- org_jetbrains_kotlin_kotlin-reflect 1.7.10 via fabric-language-kotlin
- org_jetbrains_kotlin_kotlin-stdlib 1.7.10 via fabric-language-kotlin
- org_jetbrains_kotlin_kotlin-stdlib-jdk7 1.7.10 via fabric-language-kotlin
- org_jetbrains_kotlin_kotlin-stdlib-jdk8 1.7.10 via fabric-language-kotlin
- org_jetbrains_kotlinx_atomicfu-jvm 0.18.3 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.6.4 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.6.4 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-datetime-jvm 0.4.0 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.4.0 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.4.0 via fabric-language-kotlin
- org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.4.0 via fabric-language-kotlin
- org_joml_joml 1.10.4 via sodium
- org_json_json 20211205 via pickyourpoison
- overweight_farming 1.19-1.5.3-fabric
- owo 0.8.2+1.19
- oxidized 1.7.2
- patchouli 1.19.2-76-FABRIC
- pickupnotifier 4.2.0
- pickyourpoison 1.0.9
- pinlib 0.1.3+1.19 via fwaystones
- player-animator 0.3.5
- polymorph 0.45.0+1.19.2
- pride 1.1.2+1.19 via lambdynlights
- profundis 1.4.1
- promenade 2.7.1
- puddles 1.2.2
- purpeille 3.2.0+fabric-1.19
- puzzle 1.4.0-1.19
- puzzle-base 1.4.0-1.19 via puzzle
- puzzle-gui 1.4.0-1.19 via puzzle
- puzzle-models 1.4.0-1.19 via puzzle
- puzzle-splashscreen 1.4.0-1.19 via puzzle
- puzzleslib 4.3.4
- raised 1.1.2
- reach-entity-attributes 2.3.0 via beaconoverhaul
- reeses-sodium-options 1.4.7+mc1.19.2-build.59
- resourcefullib 1.1.9 via highlight
- rocks 1.6.1
- roundalib 0.2.1 via enchantmentcompat
- sandwichable 1.3.a+1.19
- satin 1.8.0 via blur
- scout 1.1.1
- seasons 1.4-BETA+1.19
- showmeyourskin 1.3.4+1.19
- shulkerboxtooltip 3.1.3+1.19.2
- simple-rpc 3.1.1
- skilled_enchanting 1.0.0
- skinlayers 1.5.1-mc1.19.1
- sleepwarp 1.2.0+1.19
- smoothboot 1.19-1.7.1
- sneaky 1.1
- sodium 0.4.4+build.18
- sodium-extra 0.4.10+mc1.19.2-build.64
- soundcategories 1.2.4+1.19 via extrasounds
- spark 1.9.36
- sparkle 1.0.3
- spectrelib 0.10.0+1.19 via veinmining
- spruceui 4.0.0+1.19 via enhancedblockentities
- starlight 1.1.1+fabric.ae22326
- step-height-entity-attribute 1.0.0 via enchancement
- steves_vanilla 1.19.2+2.0.1
- stonecutter_recipe_tags 4.0.0+1.19.9b8d04c.fabric via consistency_plus
- striders-grace 1.0.0
- structory 1.0.1
- t_and_t 1.8.2
- terrablender 2.0.1.125 via traverse
- terraform-biome-remapper-api-v1 4.1.1 via cinderscapes
- terraform-config-api-v1 4.1.1 via traverse
- terraform-shapes-api-v1 4.1.1 via cinderscapes
- terraform-surfaces-api-v1 4.1.1 via traverse
- terraform-tree-api-v1 4.1.1 via traverse
- terraform-wood-api-v1 4.1.1 via cinderscapes
- terralith 2.3
- things 0.2.20+1.19
- tinkerers-smithing 0.0.1
- tinyconfig 1.0.2 via bettercombat
- tooltipfix 1.0.5-1.19
- traverse 6.0.1
- traverse-client 6.0.1 via traverse
- traverse-common 6.0.1 via traverse
- traverse-worldgen 6.0.1 via traverse
- trinkets 3.4.0
- trinkets-curios-theme 0.2.2+1.19
- tweed4_annotated 1.3.1+mc22w17a via mousewheelie
- tweed4_base 1.6.0+mc22w17a via mousewheelie
- tweed4_data 1.2.1+mc22w17a via mousewheelie
- tweed4_data_hjson 1.1.1+mc22w17a via mousewheelie
- tweed4_tailor_coat 1.1.3+mc22w17a via mousewheelie
- tweed4_tailor_screen 1.1.1+mc22w17a via mousewheelie
- twigs 2.0.0-beta.9+1.19-fabric
- universal_ores 1.4.2
- universalbonemeal 4.2.0
- veinmining 1.0.0-beta.1+1.19.2
- visuality 0.5.1
- visualworkbench 4.2.0
- voidcrafting 1.7.2+fabric-1.19 via purpeille
- voidfog 2.7.0
- voidz 1.0.9
- wandering_collector 1.1.3+mc1.19
- wardenloot 1.0.9-1.19.x
- waterdripsound 1.19-0.3.0
- wilderwild 1.0.6-Fabric+1.19.2
- yigd 1.4.3
- zoomglass 1.1I checked with roughly enough items 1.19.2 as well and they didnt show up there either.
LVRBetterEnd.zip
This is the datapack in question.
I have talked with Emi, the dev of EMI and she told me that the recipe integration on EMI side is automatic and that adding the recipes is exclusively handled by the recipe's mod itself.
The recipes do appear when using r on items that are used WITH the recipes but they dont appear when trying to view the recipe specific to that item.
My good guess is that BetterEnd does not recognize that these items from other mods are actually being crafted with these custom recipes and thats why it wont give a recipe output in the inventory mods.
Nope, it doesnt. I've also noticed a peculiar little thing about the crafted recipes:
As you may see, enchantment description dont display as well as the item rarity being different.
Thanks for noticing this and supplying a datapack.
The way this is currently implemented does not check for new recipes added by data packs. But I will have look. This should also be a problem on REI.
Ok, so I did some testing, and added a simple datapack, that has an infusion recipe for stone:
{
"type": "betterend:infusion",
"input": {
"item": "minecraft:book"
},
"result": {
"item": "minecraft:stone",
"count": 64
},
"time": 300,
"catalysts": {
"north": "betterend:enchanted_petal",
"north_east": "minecraft:lapis_lazuli",
"east": "minecraft:sugar",
"south_east": "minecraft:lapis_lazuli",
"south": "minecraft:powered_rail",
"south_west": "minecraft:lapis_lazuli",
"west": "minecraft:sugar",
"north_west": "minecraft:lapis_lazuli"
}
}EMI appears to pick it up as it should, and clicking the stone item will also show the correct Page:
So, simple Infusion Recipes from Datapacks appear to get loaded just fine in EMI...
Ok, I just built another simple one, that should generate an enchanted book:
{
"type": "betterend:infusion",
"input": {
"item": "minecraft:book"
},
"result": {
"item": "minecraft:enchanted_book",
"nbt": "{StoredEnchantments:[{id:\"minecraft:sharpness\",lvl:1s}]}",
"count": 1
},
"time": 300,
"catalysts": {
"north": "betterend:enchanted_petal",
"north_east": "minecraft:lapis_lazuli",
"east": "minecraft:stone",
"south_east": "minecraft:lapis_lazuli",
"south": "minecraft:sugar",
"south_west": "minecraft:lapis_lazuli",
"west": "minecraft:stone",
"north_west": "minecraft:lapis_lazuli"
}
}That also appears to be working:
I think I see the Problem now. The Enchantment not line in the example is like this:
{Enchantments:[{id:"minecraft:sharpness",lvl:1}]}
but it should be:
{StoredEnchantments:[{id:"minecraft:sharpness",lvl:1s}]}
Could you please check if that helps?
Also I added the requested support for NBT-Tags in the input slot.
Thank you Quiqueck, I will try today. Did you also fix NBT Crafting compatibility relating to anvils?
Thank you Quiqueck, I will try today. Did you also fix NBT Crafting compatibility relating to anvils?
Not Yet, no.