BetterFps

BetterFps

91M Downloads

Running the mod in dev environment (for debugging compatibility issue)

Barteks2x opened this issue ยท 8 comments

commented

I'm trying to debug this issue: OpenCubicChunks/CubicChunks#184. To do that I'm trying to run BetterFPS in my mod dev environment. But when I try to run it, the game crashes: (full log) https://pastebin.com/88T5Weqk

I don't see anything obvious in my or BetterFPS code that could cause it. What do I need to do to make it run in dev environment?

commented

The mod is not compiled for dev environment, that's why it doesn't work. I can give you a dev build tomorrow, if you want.

The only line of code that BetterFps changes is this one. It adds that line in the start of EntityRenderer.setupFog.

commented

I think I've found the problem, I'll try to fix it ASAP

commented

I can make a dev build myself if that's the issue. I just didn't see any actual BetterFPS code in the stacktrace so I assumed ti was something wrong with bytecode transformation.

You said you found the problem - are you talking about the one I was trying to debug? I really wouldn't expect anyone to support my crazy hackery.

commented

The problem is with the clouds option, for some reason, when they're disabled, the fog starts to render.

This is also related to #53. Feel free to close the issue in your mod, this is all BetterFps' fault :P

commented

Yep, this was definitely caused by an update. It doesn't happen with clouds enabled because EntityRenderer.renderCloudsCheck disables the fog.
I'd say it's a problem with the game itself, it leaves an inconsistent fog state after EntityRenderer.renderWorldPass

The whole point of BetterFps is to improve the performance of the game without conflicting with other mods. I don't care if your mod does some crazy hackery, I have to make them work together, or at least help you fixing it

commented

I think this was the issue that was causing the fog to not work, I'll build your mod tomorrow and try it out. Feel free to reopen this issue :)

commented

The bug report said there was too much fog above clounds level. And I even have trouble reproducing it.

commented

I was able to reproduce it now. I will try to build that version of BetterFPS to test it. Now that I see how it happens what you said makes sense and my speculation was just completely wrong in every way possible.