BetterGrassify

BetterGrassify

149k Downloads

Crash when going to ESC menu after updating

vico93 opened this issue ยท 6 comments

commented

Describe the bug
Just got this crash when trying to press ESC after connecting in a server after updating both FabricBetterGrass and adding a forked version of BorderlessMining by @sky-is-winning to my modpack. Seems to be a mixin error.

Desktop

  • OS: Windows 10 x64
  • Minecraft 1.21
  • Fabric Loader 0.16.0-1.21
  • Mods Fabric API 0.100.7+1.21, Borderless Mining 1.1.10-dev.4c1df01+1.21, FabricBetterGrass 1.0.18+1.21
  • Version 1.0.18
commented

@sky-is-winning you can change the mixin priority for the time-being, to make your fork compatible with other mods.

- @Mixin(VideoOptionsScreen.class)
+ @Mixin(value = VideoOptionsScreen.class, priority = 990)

it seems that you are replacing every option from the video settings screen, which leads to a mixin priority conflict.

commented

@sky-is-winning you can change the mixin priority for the time-being, to make your fork compatible with other mods.

- @Mixin(VideoOptionsScreen.class)
+ @Mixin(value = VideoOptionsScreen.class, priority = 990)

it seems that you are replacing every option from the video settings screen, which leads to a mixin priority conflict.

I never imagined Borderless Mining was doing that... i thoguht that mod was just to make the game fullscreen to be borderless windowed :P

commented

The existing mixin implementation in Borderless Mining doesn't do that and it's perfectly compatible with other mods.
sky-is-wining have to correct their mixin.

It is just a simple mixin to add a borderless fullscreen option to the vanilla video settings screen...

commented

You should inform @sky-is-winning about the crash, instead!
Other mods too, that add a config option on the vanilla video settings screen, will face a similar crash.

commented

Yup, same issue as I had with Iris.

commented

The existing mixin implementation in Borderless Mining doesn't do that and it's perfectly compatible with other mods. sky-is-wining have to correct their mixin.

It is just a simple mixin to add a borderless fullscreen option to the vanilla video settings screen...

I'm not a java mod dev lol, I just wanted my game to not crash when using this mod. My bodged fix works fine for me.
If you want to improve it, feel free to.