BetterGrassify

BetterGrassify

149k Downloads

Better snow applies to doors (both top and bottom parts)

BlueJayofEvil opened this issue ยท 4 comments

commented

Describe your issue

The better snow function applies itself to doors. Both the top and bottom portions are affected. I tried with both OptiFine-like and LambdaBetterGrass-like modes. This can be commonly seen in the snowy igloo-like houses that generate in snowy plains villages due to the doorways being surrounded by snow blocks.
Adding doors to the excluded tags fixes this, so a possible solution could be to add that to the default excluded tags to prevent this issue.

Mod version

1.3.0+fabric.1.21.1

Launcher

Prism Launcher

Additional context

Examples:
2024-11-08_22 30 22
2024-11-08_22 30 23
2024-11-08_22 31 55

After adding doors to the excluded tags:
2024-11-08_22 34 53

commented

On a related note, torches and lanterns also have a similar issue:
2024-11-08_23 45 27
2024-11-08_23 45 36

Adding them to the exclusion list doesn't seem to work in this case.

EDIT: I've worked around torches and lanterns. Apparently there's no tag for them so they have to be excluded on a per-block basis. I figure I'll exclude them from this report since anyone who doesn't want that can easily disable them. But the door issue still looks buggy by default.

EDIT 2: I've discovered torches require their specific blockstate form to be excluded (e.g. wall_torch).

commented

I've disabled doors and (redstone) wall torches.
I don't think lanterns and normal torches should be disabled.

commented

Thank you. ๐Ÿ‘
I checked the new default config and noticed soul_wall_torch isn't included on the excluded blocks. Not sure if you want to add that for consistency or not.
Also, I've tried with no success to make it ignore only hanging lanterns. Lanterns have the blockstate property "hanging: true/false" but it's not a separate block like wall torches so excluding the hanging tag doesn't work. I agree lanterns should have better snow by default, but the crux of my issue is ones hanging but also have a block underneath get the snow layer applied which I find undesirable. If there is a way to exclude only ones with "hanging: true" please let me know.
Thanks again!

commented

I checked the new default config and noticed soul_wall_torch isn't included on the excluded blocks. Not sure if you want to add that for consistency or not.

Forgot that they existed.

Also, I've tried with no success to make it ignore only hanging lanterns.

If a separate id isn't available for hanging lanterns, then I'll have to hardcode my own, like lantern[hanging=true], or something.