BetterPortals

BetterPortals

1M Downloads

Portal does not cull occluded block faces

ChloeDawn opened this issue ยท 2 comments

commented

Better Portals version: 0.1.3
Better Foliage version: MC1.12-2.2.0

The area where the portal is rendered does not cull adjacent faces that are occluded whilst the portal view is rendered. This causes issues with mod's such as Better Foliage, as seen below, where it draws additional quads for the un-culled face.

Screenshot of BetterFoliage conflict

commented

Actually, this is more troublesome to resolve than I though it would be and will probably also require changes on BetterFoliage's part. At the very least octarine-noise/BetterFoliage#173 should be fixed, which, depending on how it's implemented, might even be enough, so I'm closing this issue in favor of that one.

commented

This is a bit tricky because you actually want to see the grass when looking from the other side (below in overworld or above in nether) but I guess no floating grass in portals is better than too much floating grass in portals.

For future reference: this is the check portal blocks currently fail.