BetterPortals

BetterPortals

1M Downloads

1.14.4 TODOs

Johni0702 opened this issue · 0 comments

commented

General

  • Do not include forge/fabric mod manifest in the other version's jar
  • Stop using deprecated methods
  • Preprocessor should cleanly transform between all of them
  • Check that I didn't horribly break 1.12.2 in the process
  • Test multiplayer
  • Marking chunks for rebuild in response to receiving neighboring chunks doesn't seem to work
    properly
  • Block collision hooks
  • Maybe split mod into one child mod per portal type (would solve the early loading issue in the forge section, since one can then just un-install the submod instead of disabling it in the config)
  • Rewinding world changes on teleport is broken (integration tests failing and manual testing seems to confirm it)
  • EntityTraversalRenderTests are failing, manual tests seem fine though

Forge

  • Check that I didn't break Forge 1.14 while porting to Fabric 1.14 (for workarounds to run in dev env see 803df56)
  • Figure out how much (if anything) of the network handshake we need to simulate for views on server and client
  • Test end portal
  • Implement enhanced third-party transfers (entity placement)
  • Either config file needs to be loaded early or we need a way to dynamically enable/disable registry overwrites? → Split mod into multiple modules. So not installing some part of it is an option (would be better with jar-in-jar but that's currently broken in 1.14 forge).
  • Get integration tests running again
  • Runs outside of development environment (for workarounds, see 803df56, proper release blocked on MinecraftForge/MinecraftForge#6557): currently causes stackoverflow in func_223438_b; haven't tried dev env in a while, so might happen there as well
  • Dedicated server? (partially blocked on running outside of dev env)
  • Optifine? (blocked on running outside of dev env)

Fabric

  • Test end portal
  • FOV hook
  • Hooks to make sure the view-camera is never considered to be inside a block/fluid (all handily redirected to ActiveRenderInfo.getBlockAtCamera by forge) → we already handle fluids and block handling is not actually required: the forge method isn't actually called anywhere, vanilla uses Entity.isInsideWall(), etc
  • Block outline hook
  • Implement enhanced third-party transfers (entity placement and render hook)
  • Support fabric-dimensions-v1 (EntityPlacer) in enhanced third-party transfers
  • What to do about the NoSuchMethodError in JsonGlProgram mixin? (probably workaround until fabricloader upgrades to Mixin 0.8)
  • What to do about the channelRead0 thing? → fixed by updating yarn
  • Figure out better workaround for the fact that fabric only supports singe-directory resource packs (we have multiple source sets) → we now have one mod per source set (except only one for main+api but that seems fine)
  • Get integration tests running again
  • Runs outside of development environment
  • Entities in the destination world sometimes flicker when the player (not the camera!) switches worlds (might be a 1.14 thing, only tested fabric)
  • Dedicated server?
  • Optifine? (via Optifabric)