Better Smithing Table

Better Smithing Table

552k Downloads

Random crash / Mod incompatibility - Latest version 1.20.2

sternschnaube opened this issue · 21 comments

commented

When I try to open the GUI:

Unreported exception thrown!
java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_4895 failed
at net.minecraft.class_3929.(class_3929.java:103)
at net.minecraft.class_634.method_17587(class_634.java:1150)
at net.minecraft.class_3944.method_17591(class_3944.java:37)
at net.minecraft.class_3944.method_11054(class_3944.java:11)
at net.minecraft.class_2600.method_11072(class_2600.java:23)
at net.minecraft.class_1255.method_18859(class_1255.java:156)
at net.minecraft.class_4093.mixinextras$bridge$method_18859$5(class_4093.java)
at net.minecraft.class_4093.wrapOperation$dhk000$carpet-tis-addition$yeetUpdateSuppressionCrash_implForThreadExecutorTaskExecuting(class_4093.java:570)
at net.minecraft.class_4093.method_18859(class_4093.java:23)
at net.minecraft.class_1255.method_16075(class_1255.java:130)
at net.minecraft.class_1255.method_5383(class_1255.java:115)
at net.minecraft.class_310.method_1523(class_310.java:1231)
at net.minecraft.class_310.method_1514(class_310.java:856)
at net.minecraft.client.main.Main.main(Main.java:253)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_4895 failed
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
... 17 more
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
at io.gitlab.jfronny.libjf.unsafe.asm.AsmTransformer.transformClassBytes(AsmTransformer.java:75)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
... 21 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector renderBg(Lnet/minecraft/class_8064;Lnet/minecraft/class_1703;Lnet/minecraft/class_332;FII)V in mixins.brb-common.json:SmithingScreenMixin from mod brb failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap brb-common-refmap.json
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1384)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1062)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:402)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
... 25 more

commented

These two are two very different cases since they happen with different versions of the mod, so I will examine them separately. I will close this issue when both are fixed.

commented

When I try to open the GUI:

Unreported exception thrown! java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_4895 failed at net.minecraft.class_3929.(class_3929.java:103) at...

I've tried to recreate this error on the newest version on Curseforge and had no success. Can you verify if you are really using the newest version?

commented

I highly assume it's a mod compatibility error. But now you can't make a use of my mod list, since it's too big.

If I find time I could investigate more into it and spot which mod is creating this issue.

commented

I highly assume it's a mod compatibility error. But now you can't make a use of my mod list, since it's too big.

If I find time I could investigate more into it and spot which mod is creating this issue.

Can you upload the full crash log so I can investigate what specifically might be failing? If you are using fabric it would also be great to install the mixintrace mod beforehand to give me some extra information on what might be going wrong.

commented

I will do that later 😊

commented

Saem, for some reason I am also getting a crash on start for some reason. If I disable the mod things work. I am on 1.20.1 https://mclo.gs/J49MkRd

This is probably a mod compatibility problem aswell. From the crash log it looks like another mod is messing with the dynamic slot icons in the smithing menu so BetterSmithingTable fails when trying to prevent them from rendering. If you are using a publically available modpack you can share it with me so i can attempt to debug the issue with your configuration.

commented

I think it might be one of these:
image

Not using a public modpack, just some mods that I like. I removed half of the mods I play with, mostly major mods, and this crash still happens when better smithtable is installed.
crash-2024-01-04_13.15.06-fml.txt
the crash also has the mods installed

Dungeons and Taverns Pillager
Not Enough Crashes
Reimagined Trims
GeckoLib 4
Player Animator
Extra Trades
Blasting/Smelting Metal Blocks
The Aether
Tips
BetterSmithingTable
Dynamic Villager Trades
KleeSlabs
Dungeons and Taverns Ancient Cities
Controlling
Placebo
MixinExtras
EMI Trades
Bookshelf
Guard Villagers
Condensed Creative
Just Enough Effects Descriptio
Clean Tooltips
Balm
Carry On
Just Enough Resources
Cloth Config v10 API
Dragon Mounts: Legacy
Copper Drops
Auto Third Person
Easy Piglins
Detected setBlock Be Gone
Corpse
Advancement Plaques
Entity Model Features
Entity Texture Features
Curious Armor Stands
Better Tags
Hey Berry! SHUT UP
Botania
Fishingreal
Additional Placements
Curios API
Patchouli
Corail Woodcutter
ArmorPoints++
Searchables
Dungeons and Taverns
Apothic Attributes
Better Third Person
Combat Next
Emissivity
Chiseled Bookshelves Add Encha
Cumulus
Inventory Profiles Next
Sapience
Architectury
Better Recipe Book
Separated Leaves
Nitrogen
Jade Addons
ChickensShed
Disenchanting
Crawl on Demand
Funtional Armor Trim
Better Advancements
SmartBrainLib
Elytra Slot
Kiwi Library
Flat Bedrock
AttributeFix
Caelus API
Passable Foliage
Forgotten Pots
Extra Compat
Clumps
Bad Packets
SherdDuplication
Neruina
Dave's Potioneering
Catalogue
Forge
Blood Magic
Liberty's Villagers
Minecraft
Capable Composters
CoFH Core
Thermal Series
Thermal Integration
Thermal Foundation
EMI
EMI Loot
libIPN
EnchantmentDescriptions
Radiant Gear
Moonlight Library
Mouse Tweaks
Companion
Better Combat
Titanium
MixinSquared
Rebalanced Piglin Bartering
Jade
Shoulder Surfing
SpectreLib
Ding
Kotlin For Forge
Easy Villagers
NotEnoughAnimations Mod
Iceberg
JAOPCA
Polymorph
Just Enough Professions (JEP)
AlmostUnified
Just Enough Items
Modonomicon
Capable Cauldrons
AppleSkin
Occultism
Functional Storage
Charm of Undying
Aquaculture 2
Convenient Curios Container
OpenLoader

commented

Actually looking at the code there is no reason this mod should mess with BetterSmithingTable, but please still try without it.

I also tested other UI mods, and both Better Recipe Book, and Recipe Book is Pain are causing the problem.

commented

I think it might be one of these: [...]

Not using a public modpack, just some mods that I like. I removed half of the mods I play with, mostly major mods, and this crash still happens when better smithtable is installed. crash-2024-01-04_13.15.06-fml.txt the crash also has the mods installed

[...]

I can see an error caused by the mod in the crash report but it's weirdly merged with fault in the Corpse mod. This might be because the two are incompatible, but it could also just be some weirdness in the way the error is logged. Try removing the Corpse mod and opening the smithing interface again.
If the issue still persists please upload the crash report again so I check if anything changed.

commented

Actually looking at the code there is no reason this mod should mess with BetterSmithingTable, but please still try without it.

commented

Thanks @ffuentesm, I use Better Recipe Book too, maybe that's the issue mod. I will investigate soon into it.

commented

I can confirm that Better Recipe Book is the problem here.

I am using version: brb-1.10.0+1.20.2

commented

Saem, for some reason I am also getting a crash on start for some reason. If I disable the mod things work.
I am on 1.20.1
https://mclo.gs/J49MkRd

commented

Ok, thanks for reporting this. I will investigate and try to get a fix out by tomorrow.

commented

Awesome 😊

commented

Ok, I assume this issue can be closed now. I will look at Better Recipe Book and check if I can make the two compatible.

commented

Ah yes, the incompatibiliy is very obvious. The same method call is being redirected once in BetterRecipeBook and once in BetterSmithingTable. The fix should not be too hard though.

commented

I will close this issue after the fix is ready.

commented

Thank you!! 🥳

commented

Thank you, I will update to that version soon.

commented

Ok, the fix is in the new version for 1.20.2 - 1.20.4. The fix for 1.20.1 will take a little more time as I need to repeat the changes for the 1.20.1 version. I will close this issue once that is completed.