Bewitchment (Legacy)

Expected Behavior

Infusions are kept after death but their MP emptied

Actual Behavior

Dying removes the infusion and reverts it back to the default

Steps to Reproduce

Set up any infusion (I used "Infusion of the Flames" for this, but I'd assume any others would work)
Kill yourself somehow
Respawn with the default power bar

Version of Minecraft, Bewitchment, Forge, Patchouli, LLibrary and Baubles used

MC 1.12.2
BW 0.19.16
Forge .2814
Patchouli 1.0-16
Llibrary: 1.7.17-1.12.2
Baubles: 1.13-1.5.2

Screenshots encouraged

https://imgur.com/a/H2hReuN

Logs, in the event of a crash

N/A

It looks like the infusion type isn't saved with the other capabilities on player death. I don't have time to set this up in my dev environment or test that the fix works today, but it just needs one line of code. Add

CapabilityHelper.copyDataOnPlayerRespawn(event, InfusionCapability.CAPABILITY);

after line 28.

Bewitchment/src/main/java/com/bewitchment/common/core/event/EnergyEvents.java

Lines 24 to 30 in 5ee1034

    
           @SubscribeEvent 
        
           public static void onPlayerClone(net.minecraftforge.event.entity.player.PlayerEvent.Clone event) { 
        
           	if (event.isWasDeath()) { 
        
           		CapabilityHelper.copyDataOnPlayerRespawn(event, IMagicPowerContainer.CAPABILITY); 
        
           		CapabilityHelper.copyDataOnPlayerRespawn(event, CapabilityMPExpansion.CAPABILITY); 
        
           	} 
        
           }

It looks like this issue should be closed. Sunconure11 took care of it

	@SubscribeEvent
	public static void onPlayerClone(net.minecraftforge.event.entity.player.PlayerEvent.Clone event) {
	if (event.isWasDeath()) {
	CapabilityHelper.copyDataOnPlayerRespawn(event, IMagicPowerContainer.CAPABILITY);
	CapabilityHelper.copyDataOnPlayerRespawn(event, CapabilityMPExpansion.CAPABILITY);
	}
	}