Bewitchment

Bewitchment

7M Downloads

Incompatibility with Age of Exile

kissedbytherains opened this issue ยท 12 comments

commented

Running just Bewitchment and Age of Exile together and fabric api/their dependencies (pictured) I can replicate a bug where I fly out in creative mode and terrain will stop generating suddenly, usually cutting off in a uniform line. Block updates stop as well - placing water will place it on a block but it won't spread. Exiting out of the game once this happens doesn't work normally and I have to kill process through multimc. Sometimes I'm unable to finish world generation as well and it will freeze up somewhere between 90-100%.

Minecraft 1.16.5
MultiMC Launcher 0.6.11-1430
Fabric Loader 0.11.2

image

image

Log for freeze while generating world:
https://pastebin.com/j0xQ9CZe

This world was working until I exited the world and rejoined, then I got the same kind of chunk error where they stopped loading in a line.
https://pastebin.com/5y5pC8Me

this one was a straightforward freeze once I'd flown about 1k blocks out:
https://pastebin.com/J9YctVXV

commented

I don't think I can read the concrete issue from the logs, I'll try to replicate it.

commented

Also noticing that you are running this with Java 15; most mods use Java 8 and there have been repeated issues regarding using older versions.

Try running specifically with Java 8: https://github.com/MultiMC/MultiMC5/wiki/Using-the-right-Java#macos

commented

Can confirm the issue, trying to narrow it down

You might be better off opening an issue on the Age of Exile issue tracker: https://github.com/RobertSkalko/Age-of-Exile/issues, since BW uses vanilla methods for worldgen (mobs & trees) as far as I'm aware

commented

Update: it seems like Age of Exile prevents any of BW's trees or entities to spawn naturally

This might be an issue of Age of Exile's half

commented

I don't remember preventing anything but I do add a lot of mobs to spawn lists. I didn't have any other mod cause an issue like this, maybe bewitchement has a mob spawning while loop somewhere?

commented

Okay, I'll post an issue over there. Thank you for looking into it and yeah I should have toggled java versions just to make sure

commented

Btw did you confirm no freeze if you leave out AoE or BW?

commented

I've been building a modpack for myself for a few months with a decent # of mods and Age of Exile was one of them. I'd noticed I was getting the freeze sometime after I recently added Bewitchment to the list and things would seem to work fine with it excluded, but I didn't know where the conflict could be so I tried both experimenting with no shaders, sodium, iris, canvas, optifine, and also adding mods group by group to a new instance starting with bewitchment and found I got the freeze once I'd added AoE. Before that I'd test mod updates and additions in a looser way just to make sure everything booted and world creation and a feature or two worked so I likely missed exactly when the freezes were introduced. I'd like to test it in a little bit just to doubly make sure in a more controlled way, but I hadn't had issues with Age of Exile in the pack afaik before that.

commented

All entities in Bewitchment are currently registered using the Biome API

BiomeModificationImpl.INSTANCE.addModifier(CONFIGURED_FEATURES.get(SILVER_ORE), ModificationPhase.ADDITIONS, BiomeSelectors.foundInOverworld(), context -> context.getGenerationSettings().addBuiltInFeature(GenerationStep.Feature.UNDERGROUND_ORES, SILVER_ORE));

I also don't know about that trees not appearing thing, it's really confusing

commented

So I've done some extra tests using this pattern:

10 test passes
New instance, fabric install, boot mc, close, add mods/dependencies needed + fabric api, re-open

[New world
Enable Cheats: on
Enter creative mode
Fast fly southward to z 1000+
Save and quit
Delete world
Repeat]

solo AoE
image
10/10 Runs Clear - no issue

Solo Bewitchment
image
10/10 Runs Clear - no issue

Combined
image

Attempt 1/10 Clear! ~z 1000+
derped on paste
Attempt 2/10 fail @ ~z 990 had to kill instance
https://pastebin.com/z2ZY4x3N
Attempt 3/10 fail @ ~z 79 had to kill instance
https://pastebin.com/PkG2nhts
Attempt 4/10 fail @ ~z 400 had to kill instance
(forgot to copy/paste log)
Attempt 5/10 load fail
https://pastebin.com/Thf2ZSmP
Attempt 6/10 fail @ ~z 60 had to kill instance
https://pastebin.com/ThNg331B
Attempt 7/10 load fail
https://pastebin.com/MNeBrzyu
Attempt 8/10 Clear! z 1000+
https://pastebin.com/MszHJ0BL
Attempt 9/10 load fail
https://pastebin.com/mQhQR5Mb
Attempt 10/10 Clear! z 1000+
https://pastebin.com/KABTYgg4

Now again with Java 8 vs AdoptOpenJDK 15 and new instance
Attempt 1/10 Clear! ~z 1000+ (over ocean largely)
https://pastebin.com/H45A6DUN
Attempt 2/10 fail @ ~z 367 had to kill instance
https://pastebin.com/zMra9MS0
Attempt 3/10 Clear! ~z 1000+ (over ocean largely)
https://pastebin.com/Xmz1ejM1
Attempt 4/10 load fail
https://pastebin.com/taiVh991
Attempt 5/10 fail @ ~z 366 had to kill instance
https://pastebin.com/KGKMEPr1
Attempt 6/10 Clear! ~z 1000+ (no ocean)
https://pastebin.com/0udXbN6G
Attempt 7/10 Clear! ~z 1000+ (no ocean)
https://pastebin.com/FR8NZx8X
Attempt 8/10 fail @ ~z 527 had to kill instance
https://pastebin.com/mya7LYN8
Attempt 9/10 fail @ ~z 382 had to kill instance
i've used up all my 20 pastes hahaha
Attempt 10/10 Clear! ~z 1000+ (mostly desert)
rip pastes

started noticing over time that traveling over oceans seemed to delay the freeze bug, deserts seemed alright as well

commented

Since posting this both AoE and Bewitchment have updated and I've tried the latest versions together again in my current modpack without the same issue showing up so far. I can test them alone later but I think this might be fixed.

commented

Ye tested the two mods alone together and I'm pretty sure it's fixed, heck yeah :D