Bibliocraft Legacy

Bibliocraft Legacy

2M Downloads

[Bug]: bookcase filters don't work with automated item insertion

alcarithemad opened this issue ยท 2 comments

commented

Describe the bug

It's not possible to insert non-book items into bookcases by hand. However, automated item movers from other mods, such as AE2 storage buses and export buses, ignore the restriction.

I'm not a Minecraft modding expert, but I think this is because BCBlockEntity's item storage is done by implementing Container, which the Neoforge docs seem rather insistent is only retained for vanilla compatibility.

If that is the cause, then rewriting the storage logic to use IItemHandler seems to be the thing to do.

Steps to Reproduce

Create a basic AE2 network with a creative energy cell, chest connected to an import bus, and a bookcase connected to a storage bus. Put a fish in the chest. Wait a moment for the fish to be imported and stored in the bookcase.

Expected behavior

Automated item movers should respect the "books only" filter on bookcase slots.

Screenshots

Image

Image

Version

1.21.1-1.5.4

NeoForge Version

21.1.177

Other Mods

appliedenergistics2-19.2.12.jar
bibliobiomes-1.21.1-1.5.0.jar
bibliocraft-1.21.1-1.5.4.jar
bibliowoods-1.21.1-1.5.2.jar
guideme-21.1.9.jar
jei-1.21.1-neoforge-19.21.2.313.jar

Log

Code of Conduct

  • I agree to follow this project's Code of Conduct
commented

This should be fixed as of 1.6.1. Of note, I did not perform any testing beyond the setup you provided. If you can find more obscure cases, feel free to reopen this issue. Thank you for reporting!

commented

Thank you for reporting! I will look into this.