Big Reactors

Big Reactors

11M Downloads

lang file conflict with EnderTech

algul opened this issue ยท 9 comments

commented

both EnderTech and BigReactor define tile.multiblockGlass.0.name in the lang file. Mod that loads last will overwrite name of both blocks.

commented

Well, that's suboptimal. I'll rename this for 0.5.

commented

Have you submitted an issue to EnderTech as well?

commented

Correct, I'm only going to change the unlocalized name. I believe it's already mapped to "brMultiblockGlass" as the blockID name.

commented

Ayep, it's BRMultiblockGlass for IDs, so this can be changed without conflicts: https://github.com/erogenousbeef/BigReactors/blob/master/src/main/java/erogenousbeef/bigreactors/common/BigReactors.java#L595

Bumping to 0.4.

commented

yes, i did. I asked first on forge forum if it's languageregistry issue and lexmanos told me it's mod issue. I don't know if there are any naming conventions so I submitted id to both.

commented

Yeah, "multiblock" is a generic word. I'm just surprised this only came up now. I'll switch it to "brMultiblockGlass" or something.

commented

Wouldn't it break existing reactors? No offense to EnderTech but their tanks are REALLY expensive to build, so I would guess that more ppl will have reactors than endertech tanks.

commented

I guess @erogenousbeef will only change the unlocalized name of the block and not the ID name with which it is registered. So no need to do a remap and no missing block errors ;)

commented

Will be in the next 0.4 release. No ETA.